Issue 1026753002: Oilpan: fix webkit unit tests following r192243.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1026753002: Oilpan: fix webkit unit tests following r192243. (Closed)

Created:
5 years, 9 months ago by sof

Modified:
5 years, 9 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: fix webkit unit tests following r192243. TBR=oilpan-reviews BUG=467890 NOTRY=true

Patch Set 1 #

Patch Set 2 : do not adopt on construction #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	Source/core/dom/ScriptRunnerTest.cpp	View	1	2 chunks	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026753002/20001

5 years, 9 months ago (2015-03-20 13:26:24 UTC) #3

commit-bot: I haz the power

Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=192251

5 years, 9 months ago (2015-03-20 13:26:55 UTC) #5

sof

5 years, 9 months ago (2015-03-20 13:43:08 UTC) #6

Message was sent while issue was closed.

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1024013002/ by sigbjornf@opera.com.

The reason for reverting is: Breaks windows builder,


http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder/b....

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages