Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1026733003: Files.app: Add private API to check if PiexLoader is enabled or not. (Closed)

Created:
5 years, 9 months ago by hirono
Modified:
5 years, 9 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, asvitkine+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Add private API to check if PiexLoader is enabled or not. PiexLoader is enabled only for official build. BUG=396702 TEST=None R=isherman@chromium.org Committed: https://crrev.com/a54475bee8ff34ec3ada07413938fd973950e906 Cr-Commit-Position: refs/heads/master@{#321933}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add extern. #

Patch Set 3 : Turn RunSync into Run. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/private_api_misc.h View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/file_manager_private.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/closure_compiler/externs/file_manager_private.js View 1 1 chunk +6 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (5 generated)
hirono
PTAL, thanks!
5 years, 9 months ago (2015-03-23 09:32:03 UTC) #2
mtomasz
https://codereview.chromium.org/1026733003/diff/1/chrome/browser/chromeos/extensions/file_manager/private_api_misc.h File chrome/browser/chromeos/extensions/file_manager/private_api_misc.h (right): https://codereview.chromium.org/1026733003/diff/1/chrome/browser/chromeos/extensions/file_manager/private_api_misc.h#newcode195 chrome/browser/chromeos/extensions/file_manager/private_api_misc.h:195: bool RunSync() override; RunSync is deprecated, lets use Run(). ...
5 years, 9 months ago (2015-03-23 09:44:39 UTC) #3
hirono
https://codereview.chromium.org/1026733003/diff/1/chrome/browser/chromeos/extensions/file_manager/private_api_misc.h File chrome/browser/chromeos/extensions/file_manager/private_api_misc.h (right): https://codereview.chromium.org/1026733003/diff/1/chrome/browser/chromeos/extensions/file_manager/private_api_misc.h#newcode195 chrome/browser/chromeos/extensions/file_manager/private_api_misc.h:195: bool RunSync() override; On 2015/03/23 09:44:39, mtomasz wrote: > ...
5 years, 9 months ago (2015-03-24 01:25:38 UTC) #4
hirono
@fukino - PTAL extern/file_manager_private.js @isherman - PTAL extensions/browser/extension_function_histogram_value.h and tools/metrics/histograms/histograms.xml Thanks!
5 years, 9 months ago (2015-03-24 01:30:48 UTC) #6
mtomasz
lgtm
5 years, 9 months ago (2015-03-24 01:39:23 UTC) #7
fukino
lgtm
5 years, 9 months ago (2015-03-24 01:49:59 UTC) #8
hirono
On 2015/03/24 01:49:59, fukino wrote: > lgtm @isherman - Let me do TBR for adding ...
5 years, 9 months ago (2015-03-24 02:27:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026733003/40001
5 years, 9 months ago (2015-03-24 02:27:49 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/51487)
5 years, 9 months ago (2015-03-24 02:35:14 UTC) #13
Ilya Sherman
histograms.xml lgtm
5 years, 9 months ago (2015-03-24 03:51:28 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026733003/40001
5 years, 9 months ago (2015-03-24 03:53:33 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-24 04:38:28 UTC) #17
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 04:39:07 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a54475bee8ff34ec3ada07413938fd973950e906
Cr-Commit-Position: refs/heads/master@{#321933}

Powered by Google App Engine
This is Rietveld 408576698