Issue 1026723003: Guard SIMD code with !defined(SKNX_NO_SIMD).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1026723003: Guard SIMD code with !defined(SKNX_NO_SIMD). (Closed)

Created:
5 years, 9 months ago by mtklein_C

Modified:
5 years, 9 months ago

Reviewers:
mtklein, caryclark, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Guard SIMD code with !defined(SKNX_NO_SIMD). This should make it easy to compare performance of the non-SIMD Sk2x / Sk4x code with our existing portable scalar code. I'm not adding this to SkPMFloat only because we don't have an existing scalar baseline there to compare to. We'll have to keep our wits about us: I just tried your new benchmarks, and Clang's autovectorizer produced almost as good SSE as we did with intrinsics for geo_evalquadat1 and geo_evalquadtangentat1, but not for geo_chopquadat1, which went serial. BUG=skia: Committed: https://skia.googlesource.com/skia/+/3e490b714600d10aad9d17129cfa52a45b05896c

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -12 lines)			Patch
M	src/core/Sk2x.h	View	1 2	3 chunks	+7 lines, -6 lines	0 comments	Download
M	src/core/Sk4x.h	View	1 2	3 chunks	+7 lines, -6 lines	0 comments	Download
A	src/core/SkNx.h	View	1 2	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026723003/40001

5 years, 9 months ago (2015-03-20 13:26:52 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-20 13:33:10 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/3e490b714600d10aad9d17129cfa52a45b05896c

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1026723003: Guard SIMD code with !defined(SKNX_NO_SIMD). (Closed)

Description

Patch Set 1 #

Patch Set 2 : revert SkPMFloat #

Patch Set 3 : switch #

Messages