extensions/renderer/dispatcher.cc - Issue 1026703004: Refactored extensionOptions to use the new guestViewAttributes module.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/dispatcher.cc

Issue 1026703004: Refactored extensionOptions to use the new guestViewAttributes module. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comment. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/guest_view/extension_options/extension_options_constants.cc ('k') | extensions/renderer/resources/extensions_renderer_resources.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/dispatcher.cc

diff --git a/extensions/renderer/dispatcher.cc b/extensions/renderer/dispatcher.cc

index 67ed82df87ef970d24bb9f31ad4544178ccc1d22..55a9b14a508f7ca98f2a9a659276b94d23ada2b1 100644

--- a/extensions/renderer/dispatcher.cc

+++ b/extensions/renderer/dispatcher.cc

@@ -478,6 +478,10 @@ std::vector<std::pair<std::string, int> > Dispatcher::GetJsResources() {

resources.push_back(std::make_pair(kEventBindings, IDR_EVENT_BINDINGS_JS));

resources.push_back(std::make_pair("extensionOptions",

IDR_EXTENSION_OPTIONS_JS));

+ resources.push_back(std::make_pair("extensionOptionsAttributes",

+ IDR_EXTENSION_OPTIONS_ATTRIBUTES_JS));

+ resources.push_back(std::make_pair("extensionOptionsConstants",

+ IDR_EXTENSION_OPTIONS_CONSTANTS_JS));

resources.push_back(std::make_pair("extensionOptionsEvents",

IDR_EXTENSION_OPTIONS_EVENTS_JS));

resources.push_back(std::make_pair("extensionView", IDR_EXTENSION_VIEW_JS));

@@ -1409,6 +1413,7 @@ void Dispatcher::RequireGuestViewModules(ScriptContext* context) {

// Require ExtensionOptions.

if (context->GetAvailability("extensionOptionsInternal").is_available()) {

module_system->Require("extensionOptions");

+ module_system->Require("extensionOptionsAttributes");

}

// Require ExtensionView.