Refactored extensionOptions to use the new guestViewAttributes module.

extensions/renderer/resources/guest_view/guest_view_container.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This module implements the shared functionality for different guestview
 // containers, such as web_view, app_view, etc.
 
 var DocumentNatives = requireNative('document_natives');
 var GuestView = require('guestView').GuestView;
 var GuestViewInternalNatives = requireNative('guest_view_internal');
 var IdGenerator = requireNative('id_generator');
 
 function GuestViewContainer(element, viewType) {
   privates(element).internal = this;
+  this.attributes = {};
   this.element = element;
   this.elementAttached = false;
   this.viewInstanceId = IdGenerator.GetNextId();
   this.viewType = viewType;
 
   this.setupGuestProperty();
   this.guest = new GuestView(viewType);
+  this.setupAttributes();
 
   privates(this).browserPluginElement = this.createBrowserPluginElement();
   this.setupFocusPropagation();
-
   var shadowRoot = this.element.createShadowRoot();
   shadowRoot.appendChild(privates(this).browserPluginElement);
 }
 
 // Forward public API methods from |proto| to their internal implementations.
 GuestViewContainer.forwardApiMethods = function(proto, apiMethods) {
   var createProtoHandler = function(m) {
     return function(var_args) {
       var internal = privates(this).internal;
       return $Function.apply(internal[m], internal, arguments);
@@ skipping 125 matching lines @@
   params['elementHeight'] = parseInt(elementRect.height);
   return params;
 };
 
 GuestViewContainer.prototype.dispatchEvent = function(event) {
   return this.element.dispatchEvent(event);
 }
 
 // Implemented by the specific view type, if needed.
 GuestViewContainer.prototype.buildContainerParams = function() { return {}; };
-// TODO(paulmeyer): remove once all view types use attribute objects.
-GuestViewContainer.prototype.handleAttributeMutation = function(
-    attributeName, oldValue, newValue) {};
 GuestViewContainer.prototype.onElementAttached = function() {};
 GuestViewContainer.prototype.onElementDetached = function() {};
+GuestViewContainer.prototype.setupAttributes = function() {};
 
 // Registers the browser plugin <object> custom element. |viewType| is the
 // name of the specific guestview container (e.g. 'webview').
 function registerBrowserPluginElement(viewType) {
   var proto = Object.create(HTMLObjectElement.prototype);
 
   proto.createdCallback = function() {
     this.setAttribute('type', 'application/browser-plugin');
     this.setAttribute('id', 'browser-plugin-' + IdGenerator.GetNextId());
     this.style.width = '100%';
@@ skipping 37 matching lines @@
     var internal = privates(this).internal;
     if (!internal) {
       return;
     }
     internal.elementAttached = true;
     internal.onElementAttached();
   };
 
   proto.attributeChangedCallback = function(name, oldValue, newValue) {
     var internal = privates(this).internal;
-    if (!internal) {
+    if (!internal || !internal.attributes[name]) {
       return;
     }
-    internal.handleAttributeMutation(name, oldValue, newValue);
+
+    // Let the changed attribute handle its own mutation.
+    internal.attributes[name].maybeHandleMutation(oldValue, newValue);
   };
 
   proto.detachedCallback = function() {
     var internal = privates(this).internal;
     if (!internal) {
       return;
     }
     internal.elementAttached = false;
     internal.internalInstanceId = 0;
     internal.guest.destroy();
@@ skipping 14 matching lines @@
   // Delete the callbacks so developers cannot call them and produce unexpected
   // behavior.
   delete proto.createdCallback;
   delete proto.attachedCallback;
   delete proto.detachedCallback;
   delete proto.attributeChangedCallback;
 }
 
 // Exports.
 exports.GuestViewContainer = GuestViewContainer;