Chromium Code Reviews
DescriptionFiles.app: Add touch feedback on breadcrumbs.
- When the bread crumbs is updated, we need to keep DOMs for the common path prefix to continue the animation for touch feedback.
- Made each crumbs as <button>, so I removed the unnecessary event listener for 'keydown' in location_line.js.
- Fixed minor issue on truncation algorithm, to prevent crumbs from being too small (smaller than '...').
BUG=446616
TEST=manual test: Check the animation on touch on breadcrumbs, and Check the truncation when window width is changed.
Committed: https://crrev.com/515f0f0dd9faf37b9e1fe03fbb060f98b082c97b
Cr-Commit-Position: refs/heads/master@{#321554}
Patch Set 1 #
Total comments: 2
Patch Set 2 : == -> === #
Messages
Total messages: 9 (3 generated)
|
|||||||||||||||||||||||||||||||||||||