Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Issue 1026693003: Files.app: Add touch feedback on breadcrumbs. (Closed)

Created:
5 years, 9 months ago by fukino
Modified:
5 years, 9 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Add touch feedback on breadcrumbs. - When the bread crumbs is updated, we need to keep DOMs for the common path prefix to continue the animation for touch feedback. - Made each crumbs as <button>, so I removed the unnecessary event listener for 'keydown' in location_line.js. - Fixed minor issue on truncation algorithm, to prevent crumbs from being too small (smaller than '...'). BUG=446616 TEST=manual test: Check the animation on touch on breadcrumbs, and Check the truncation when window width is changed. Committed: https://crrev.com/515f0f0dd9faf37b9e1fe03fbb060f98b082c97b Cr-Commit-Position: refs/heads/master@{#321554}

Patch Set 1 #

Total comments: 2

Patch Set 2 : == -> === #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -49 lines) Patch
M ui/file_manager/file_manager/foreground/css/common.css View 1 chunk +24 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/css/file_manager.css View 3 chunks +22 lines, -12 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/location_line.js View 1 6 chunks +92 lines, -37 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
fukino
Could you take a look? Thank you!
5 years, 9 months ago (2015-03-20 10:18:42 UTC) #2
yawano
lgtm. Thank you! https://codereview.chromium.org/1026693003/diff/1/ui/file_manager/file_manager/foreground/js/ui/location_line.js File ui/file_manager/file_manager/foreground/js/ui/location_line.js (right): https://codereview.chromium.org/1026693003/diff/1/ui/file_manager/file_manager/foreground/js/ui/location_line.js#newcode244 ui/file_manager/file_manager/foreground/js/ui/location_line.js:244: if (pathWidth == maxPathWidth) { nit: ...
5 years, 9 months ago (2015-03-20 11:14:30 UTC) #3
fukino
Thank you! https://codereview.chromium.org/1026693003/diff/1/ui/file_manager/file_manager/foreground/js/ui/location_line.js File ui/file_manager/file_manager/foreground/js/ui/location_line.js (right): https://codereview.chromium.org/1026693003/diff/1/ui/file_manager/file_manager/foreground/js/ui/location_line.js#newcode244 ui/file_manager/file_manager/foreground/js/ui/location_line.js:244: if (pathWidth == maxPathWidth) { On 2015/03/20 ...
5 years, 9 months ago (2015-03-20 11:30:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026693003/20001
5 years, 9 months ago (2015-03-20 11:30:40 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-20 12:03:55 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 12:04:36 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/515f0f0dd9faf37b9e1fe03fbb060f98b082c97b
Cr-Commit-Position: refs/heads/master@{#321554}

Powered by Google App Engine
This is Rietveld 408576698