Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 1026683002: [turbofan] Work-around untagged result of CompareIC in pointer maps. (Closed)

Created:
5 years, 9 months ago by Benedikt Meurer
Modified:
5 years, 9 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Work-around untagged result of CompareIC in pointer maps. BUG=chromium:469089 LOG=n R=jarin@chromium.org Committed: https://crrev.com/d5893cad6b4d6e9bf85dfada1de2c94734ef5823 Cr-Commit-Position: refs/heads/master@{#27333}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -25 lines) Patch
M src/compiler/arm/linkage-arm.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/arm64/linkage-arm64.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/ia32/linkage-ia32.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/linkage.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/linkage.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/linkage-impl.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/compiler/mips/linkage-mips.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/mips64/linkage-mips64.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/ppc/linkage-ppc.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/x64/linkage-x64.cc View 1 chunk +3 lines, -2 lines 0 comments Download
A + test/mjsunit/compiler/regress-469089.js View 1 chunk +10 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Benedikt Meurer
5 years, 9 months ago (2015-03-20 09:18:22 UTC) #1
Jarin
lgtm
5 years, 9 months ago (2015-03-20 09:20:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026683002/1
5 years, 9 months ago (2015-03-20 09:21:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-20 09:45:13 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 09:45:22 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d5893cad6b4d6e9bf85dfada1de2c94734ef5823
Cr-Commit-Position: refs/heads/master@{#27333}

Powered by Google App Engine
This is Rietveld 408576698