Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 1026663002: Web Audio: Don't create unnecessary DelayNode object. (Closed)

Created:
5 years, 9 months ago by tkent
Modified:
5 years, 9 months ago
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Web Audio: Don't create unnecessary DelayNode object. We can check maxDelayTime argument in the factory to avoid unnecessary DelayNode creation. This CL doesn't change user-visible behavior. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192303

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M Source/modules/webaudio/DelayNode.h View 1 chunk +2 lines, -6 lines 0 comments Download
M Source/modules/webaudio/DelayNode.cpp View 1 chunk +8 lines, -3 lines 1 comment Download

Messages

Total messages: 8 (3 generated)
tkent
Please review this.
5 years, 9 months ago (2015-03-20 08:38:23 UTC) #2
haraken
LGTM https://codereview.chromium.org/1026663002/diff/1/Source/modules/webaudio/DelayNode.cpp File Source/modules/webaudio/DelayNode.cpp (right): https://codereview.chromium.org/1026663002/diff/1/Source/modules/webaudio/DelayNode.cpp#newcode39 Source/modules/webaudio/DelayNode.cpp:39: : AudioBasicProcessorNode(NodeTypeDelay, context, sampleRate) , m_processor(new DelayProcessor(context, sampleRate, ...
5 years, 9 months ago (2015-03-20 13:42:02 UTC) #4
Raymond Toy
lgtm
5 years, 9 months ago (2015-03-20 15:24:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026663002/1
5 years, 9 months ago (2015-03-21 04:24:19 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-21 04:27:38 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192303

Powered by Google App Engine
This is Rietveld 408576698