Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 1026603002: Remove deprecated flavour of SkDropShadowImageFilter::Create(). (Closed)

Created:
5 years, 9 months ago by Stephen White
Modified:
5 years, 9 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove deprecated flavour of SkDropShadowImageFilter::Create(). Committed: https://skia.googlesource.com/skia/+/977b6f7e7b57cd7894869f3ec025e486a8208ae0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M include/effects/SkDropShadowImageFilter.h View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
Stephen White
robertphillips@: PTAL. Thanks!
5 years, 9 months ago (2015-03-20 00:04:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026603002/1
5 years, 9 months ago (2015-03-20 00:19:07 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-20 00:19:08 UTC) #5
commit-bot: I haz the power
Presubmit check for 1026603002-1 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 9 months ago (2015-03-20 00:19:14 UTC) #7
robertphillips
lgtm as long as neither Chromium nor Android use it anymore.
5 years, 9 months ago (2015-03-20 12:40:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026603002/1
5 years, 9 months ago (2015-03-20 13:10:27 UTC) #11
commit-bot: I haz the power
Presubmit check for 1026603002-1 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 9 months ago (2015-03-20 13:10:34 UTC) #13
Stephen White
reed@: PTAL for API
5 years, 9 months ago (2015-03-20 13:15:53 UTC) #14
reed1
always glad to see us deleting code :) lgtm
5 years, 9 months ago (2015-03-20 13:17:19 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026603002/1
5 years, 9 months ago (2015-03-20 13:17:37 UTC) #17
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 13:38:04 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/977b6f7e7b57cd7894869f3ec025e486a8208ae0

Powered by Google App Engine
This is Rietveld 408576698