|
|
Chromium Code Reviews|
Created:
5 years, 9 months ago by Stephen White Modified:
5 years, 9 months ago CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionRemove deprecated flavour of SkDropShadowImageFilter::Create().
Committed: https://skia.googlesource.com/skia/+/977b6f7e7b57cd7894869f3ec025e486a8208ae0
Patch Set 1 #
Messages
Total messages: 18 (7 generated)
senorblanco@chromium.org changed reviewers: + robertphillips@google.com
robertphillips@: PTAL. Thanks!
The CQ bit was checked by senorblanco@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026603002/1
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2015-03-20 06:19 UTC
The CQ bit was unchecked by commit-bot@chromium.org
Presubmit check for 1026603002-1 failed and returned exit status 1. Running presubmit commit checks ... ** Presubmit ERRORS ** Since the CL is editing public API, you must have an LGTM from one of: ('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org', 'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com')
robertphillips@google.com changed reviewers: + reed@google.com
lgtm as long as neither Chromium nor Android use it anymore.
The CQ bit was checked by senorblanco@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026603002/1
The CQ bit was unchecked by commit-bot@chromium.org
Presubmit check for 1026603002-1 failed and returned exit status 1. Running presubmit commit checks ... ** Presubmit ERRORS ** Since the CL is editing public API, you must have an LGTM from one of: ('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org', 'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com')
reed@: PTAL for API
always glad to see us deleting code :) lgtm
The CQ bit was checked by reed@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026603002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/977b6f7e7b57cd7894869f3ec025e486a8208ae0 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
