Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 1026573002: Prevent TouchEvent Crash on X (Closed)

Created:
5 years, 9 months ago by jonross
Modified:
5 years, 9 months ago
Reviewers:
sadrul
CC:
chromium-reviews, jdduke+watch_chromium.org, tdresser+watch_chromium.org, pkotwicz, tdanderson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent TouchEvent Crash on X When TouchEvents are copied the base::NativeEvent of the copy is set as null for GenericEvent types, such as touchs. Touch Release and Cancel events are set to remove a native touch id mapping upon destruction. This causes copied Touch Release/Cancel events to attempt to remove a mapping on a null native event. Leading to a crash. I've explicitly defined a copy constructor on TouchEvent to stop copied events from attempting to remove this mapping. TEST=EventsXTest.CopiedTouchEventNotRemovingFromNativeMapping BUG=467102 Committed: https://crrev.com/5444194bd4e2f4dda4725169b879af6077dd240a Cr-Commit-Position: refs/heads/master@{#321563}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M ui/events/event.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/event.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M ui/events/x/events_x_unittest.cc View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jonross
Hi Sadrul, Could you review this change? I have added a copy constructor to TouchEvent ...
5 years, 9 months ago (2015-03-19 22:34:56 UTC) #3
sadrul
lgtm
5 years, 9 months ago (2015-03-20 04:01:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026573002/20001
5 years, 9 months ago (2015-03-20 11:40:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 9 months ago (2015-03-20 13:13:53 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 13:14:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5444194bd4e2f4dda4725169b879af6077dd240a
Cr-Commit-Position: refs/heads/master@{#321563}

Powered by Google App Engine
This is Rietveld 408576698