Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Issue 1026553005: Add logging to CHECK failure during curtain-mode on Mac. (Closed)

Created:
5 years, 9 months ago by Lambros
Modified:
5 years, 9 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add logging to CHECK failure during curtain-mode on Mac. BUG=446327 Committed: https://crrev.com/c013db41d32c5da4e88a173ad03eadcab33bf974 Cr-Commit-Position: refs/heads/master@{#322098}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Log more info. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M remoting/host/curtain_mode_mac.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Lambros
5 years, 9 months ago (2015-03-24 18:48:02 UTC) #2
Jamie
lgtm https://codereview.chromium.org/1026553005/diff/1/remoting/host/curtain_mode_mac.cc File remoting/host/curtain_mode_mac.cc (right): https://codereview.chromium.org/1026553005/diff/1/remoting/host/curtain_mode_mac.cc#newcode149 remoting/host/curtain_mode_mac.cc:149: << "CGSessionCopyCurrentDictionary() returned NULL."; Can you add a ...
5 years, 9 months ago (2015-03-24 19:24:47 UTC) #3
Lambros
5 years, 9 months ago (2015-03-24 23:07:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026553005/20001
5 years, 9 months ago (2015-03-24 23:08:22 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-25 00:01:35 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 00:02:27 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c013db41d32c5da4e88a173ad03eadcab33bf974
Cr-Commit-Position: refs/heads/master@{#322098}

Powered by Google App Engine
This is Rietveld 408576698