Test Accelerators In Interactive UI Tests

Test Accelerators In Interactive UI Tests

In order to avoid future regressions.

BUG=469235
TEST=interactive_ui_tests --gtest_filter=AcceleratorInteractiveUITest.*

Committed: https://crrev.com/b0c1e2d572b2bda87f11007c89ecdaac6301770a
Cr-Commit-Position: refs/heads/master@{#322076}

[afakhry, 2015-03-23 21:59:07]

afakhry@chromium.org changed reviewers:
+ oshima@chromium.org

[afakhry, 2015-03-23 21:59:08]

Please review, Thanks!

[oshima, 2015-03-24 01:33:44]

lgtm with nits

https://codereview.chromium.org/1026513005/diff/1/ash/accelerators/accelerato...
File ash/accelerators/accelerator_interactive_uitest.cc (right):

https://codereview.chromium.org/1026513005/diff/1/ash/accelerators/accelerato...
ash/accelerators/accelerator_interactive_uitest.cc:33: //
-----------------------------------------------------------------------------
you can just move this to AcceleratorInteractiveUITest, with normal comment
format.

https://codereview.chromium.org/1026513005/diff/1/ash/accelerators/accelerato...
ash/accelerators/accelerator_interactive_uitest.cc:45: ~TestNetworkObserver()
override {}
new style guide doesn't require empty dtor. you may nuke this

[afakhry, 2015-03-24 01:51:20]

https://codereview.chromium.org/1026513005/diff/1/ash/accelerators/accelerato...
File ash/accelerators/accelerator_interactive_uitest.cc (right):

https://codereview.chromium.org/1026513005/diff/1/ash/accelerators/accelerato...
ash/accelerators/accelerator_interactive_uitest.cc:33: //
-----------------------------------------------------------------------------
On 2015/03/24 01:33:44, oshima wrote:
> you can just move this to AcceleratorInteractiveUITest, with normal comment
> format.

Done.

https://codereview.chromium.org/1026513005/diff/1/ash/accelerators/accelerato...
ash/accelerators/accelerator_interactive_uitest.cc:45: ~TestNetworkObserver()
override {}
On 2015/03/24 01:33:44, oshima wrote:
> new style guide doesn't require empty dtor. you may nuke this

Done.

[afakhry, 2015-03-24 20:59:04]

The CQ bit was checked by afakhry@chromium.org

[afakhry, 2015-03-24 20:59:04]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/1026513005/#ps80001
(title: "Disabling these tests when not in ChromeOS")

[commit-bot: I haz the power, 2015-03-24 20:59:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1026513005/80001

[commit-bot: I haz the power, 2015-03-24 21:58:48]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-03-24 21:59:44]

Patchset 5 (id:??) landed as
https://crrev.com/b0c1e2d572b2bda87f11007c89ecdaac6301770a
Cr-Commit-Position: refs/heads/master@{#322076}

[James Cook, 2015-03-25 17:18:24]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1035763003/ by jamescook@chromium.org.

The reason for reverting is: AcceleratorInteractiveUITest.ChromeOsAccelerators
and AcceleratorInteractiveUITest.TestNonRepeatableNeedingWindowActions are
failing on the cros_trunk official builders.

http://master.chrome.corp.google.com:8011/builders/cros%20trunk/builds/31840

.