Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 1026513004: Remove dangerous constructor from CompilationInfoWithZone. (Closed)

Created:
5 years, 9 months ago by Michael Starzinger
Modified:
5 years, 9 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove dangerous constructor from CompilationInfoWithZone. This removes the stub-based constructor from CompilationInfoWithZone as this class is more than a pure convenience class and only by chance doesn't have an effect in the destructor. R=titzer@chromium.org Committed: https://crrev.com/7421c7f5989b6e6df98e47eeb3d499c3b9511cbe Cr-Commit-Position: refs/heads/master@{#27376}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -16 lines) Patch
M src/code-stubs-hydrogen.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M src/compiler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-instruction.cc View 1 1 chunk +1 line, -7 lines 0 comments Download
M test/cctest/compiler/test-linkage.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Michael Starzinger
5 years, 9 months ago (2015-03-23 16:31:50 UTC) #1
titzer
https://codereview.chromium.org/1026513004/diff/1/test/cctest/compiler/test-instruction.cc File test/cctest/compiler/test-instruction.cc (right): https://codereview.chromium.org/1026513004/diff/1/test/cctest/compiler/test-instruction.cc#newcode43 test/cctest/compiler/test-instruction.cc:43: CompilationInfo info; Do we even need this field anymore?
5 years, 9 months ago (2015-03-23 17:04:34 UTC) #2
Michael Starzinger
https://codereview.chromium.org/1026513004/diff/1/test/cctest/compiler/test-instruction.cc File test/cctest/compiler/test-instruction.cc (right): https://codereview.chromium.org/1026513004/diff/1/test/cctest/compiler/test-instruction.cc#newcode43 test/cctest/compiler/test-instruction.cc:43: CompilationInfo info; On 2015/03/23 17:04:34, titzer wrote: > Do ...
5 years, 9 months ago (2015-03-23 17:10:54 UTC) #3
titzer
lgtm
5 years, 9 months ago (2015-03-23 17:18:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026513004/20001
5 years, 9 months ago (2015-03-23 17:22:05 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-23 17:30:43 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 17:30:54 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7421c7f5989b6e6df98e47eeb3d499c3b9511cbe
Cr-Commit-Position: refs/heads/master@{#27376}

Powered by Google App Engine
This is Rietveld 408576698