Allow only a user gesture to trigger autofill popup

chrome/renderer/autofill/autofill_renderer_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/test/base/chrome_render_view_test.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "components/autofill/content/common/autofill_messages.h"
 #include "components/autofill/content/renderer/autofill_agent.h"
 #include "components/autofill/core/common/form_data.h"
 #include "components/autofill/core/common/form_field_data.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/renderer/render_frame.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/WebKit/public/platform/WebString.h"
 #include "third_party/WebKit/public/platform/WebURLRequest.h"
 #include "third_party/WebKit/public/platform/WebVector.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebFormElement.h"
 #include "third_party/WebKit/public/web/WebInputElement.h"
 #include "third_party/WebKit/public/web/WebLocalFrame.h"
+#include "third_party/WebKit/public/web/WebView.h"
 
 using base::ASCIIToUTF16;
 using blink::WebDocument;
 using blink::WebElement;
 using blink::WebFormElement;
 using blink::WebFrame;
 using blink::WebLocalFrame;
 using blink::WebInputElement;
 using blink::WebString;
 using blink::WebURLRequest;
@@ skipping 203 matching lines @@
   expected.max_length = WebInputElement::defaultMaxLength();
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, forms[0].fields[7]);
 
   expected.name = ASCIIToUTF16("PHONE_HOME_WHOLE_NUMBER");
   expected.value.clear();
   expected.form_control_type = "text";
   expected.max_length = WebInputElement::defaultMaxLength();
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, forms[0].fields[8]);
 }
 
+TEST_F(AutofillRendererTest, IgnoreNonUserGestureTextFieldChanges) {
+  LoadHTML("<form method='post'>"
+           "  <input type='text' id='full_name'/>"
+           "</form>");
+
+  blink::WebInputElement full_name =
+      GetMainFrame()->document().getElementById("full_name")
+          .to<blink::WebInputElement>();
+  while (!full_name.focused())
+    GetMainFrame()->view()->advanceFocus(false);
+
+  // Not a user gesture, so no IPC message to browser.
+  full_name.setValue("Alice", true);
+  GetMainFrame()->toWebLocalFrame()->autofillClient()->textFieldDidChange(
+      full_name);
+  ProcessInputForAutofill();
+  ASSERT_EQ(nullptr, render_thread_->sink().GetFirstMessageMatching(
+                         AutofillHostMsg_TextFieldDidChange::ID));
+
+  // A user gesture will send a message to the browser.
+  SimulateUserInputChangeForElement(&full_name, "Alice");
+  ASSERT_NE(nullptr, render_thread_->sink().GetFirstMessageMatching(
+                         AutofillHostMsg_TextFieldDidChange::ID));
+}
+
+TEST_F(AutofillRendererTest, DesktopCompositionDoesNotTriggerAutofill) {
+  LoadHTML("<form method='post'>"
+           "  <input type='text' id='full_name'/>"
+           "</form>");
+
+  blink::WebInputElement full_name =
+      GetMainFrame()->document().getElementById("full_name")
+          .to<blink::WebInputElement>();
+
+  // Show the popup to verify that it will be closed on desktop.
+  SimulateUserInputChangeForElement(&full_name, "Alice");
+  render_thread_->sink().ClearMessages();
+
+  GetWebWidget()->setComposition(base::ASCIIToUTF16("Bob"),
+                                 std::vector<blink::WebCompositionUnderline>(),
+                                 3, 3);
+  ProcessInputForAutofill();
+
+#if defined(OS_ANDROID)
+  // Android will keep the popups open and will trigger autofill when IME is
+  // composing.
+  ASSERT_NE(nullptr, render_thread_->sink().GetFirstMessageMatching(
+                         AutofillHostMsg_TextFieldDidChange::ID));
+  ASSERT_EQ(nullptr, render_thread_->sink().GetFirstMessageMatching(
+                         AutofillHostMsg_HidePopup::ID));
+#else
+  // Desktop will close popups and will not trigger autofill when IME is
+  // composing, because the IME UI can overlap the autofill UI.
+  ASSERT_EQ(nullptr, render_thread_->sink().GetFirstMessageMatching(
+                         AutofillHostMsg_TextFieldDidChange::ID));
+  ASSERT_NE(nullptr, render_thread_->sink().GetFirstMessageMatching(
+                         AutofillHostMsg_HidePopup::ID));
+#endif
+}
+
 class RequestAutocompleteRendererTest : public AutofillRendererTest {
  public:
   RequestAutocompleteRendererTest()
       : invoking_frame_(NULL), sibling_frame_(NULL) {}
   ~RequestAutocompleteRendererTest() override {}
 
  protected:
   void SetUp() override {
     AutofillRendererTest::SetUp();
 
@@ skipping 58 matching lines @@
 };
 
 TEST_F(RequestAutocompleteRendererTest, InvokingTwiceOnlyShowsOnce) {
   // Attempting to show the requestAutocomplete dialog again should be ignored.
   invoking_frame_->autofillClient()->didRequestAutocomplete(invoking_form());
   EXPECT_FALSE(render_thread_->sink().GetFirstMessageMatching(
       AutofillHostMsg_RequestAutocomplete::ID));
 }
 
 }  // namespace autofill