Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 1026483003: Remove SiblingTraversalStrategies include from StyleResolver. (Closed)

Created:
5 years, 9 months ago by rune
Modified:
5 years, 9 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-style_chromium.org, dglazkov+blink, eae+blinkwatch, ed+blinkwatch_opera.com, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove SiblingTraversalStrategies include from StyleResolver. SiblingTraversalStrategies were unused in StyleResolver.h, but some files relied on ElementTraversal being included via StyleResolver.h. R=jchaffraix@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192384

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M Source/core/css/resolver/StyleResolver.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Fullscreen.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/htmlediting.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAreaElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/PopupMenuImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
rune
Split out from https://codereview.chromium.org/1023393002/
5 years, 9 months ago (2015-03-23 17:06:50 UTC) #1
Julien - ping for review
lgtm
5 years, 9 months ago (2015-03-23 17:31:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026483003/1
5 years, 9 months ago (2015-03-23 17:32:02 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/29579)
5 years, 9 months ago (2015-03-23 17:38:31 UTC) #6
rune
Added adamk@ for Source/web
5 years, 9 months ago (2015-03-23 17:41:15 UTC) #8
Julien - ping for review
+Nate/Philip: Can I haz a web/ OWNER stamping?
5 years, 9 months ago (2015-03-23 17:41:40 UTC) #10
adamk
lgtm for Source/web
5 years, 9 months ago (2015-03-23 17:43:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026483003/1
5 years, 9 months ago (2015-03-23 18:13:27 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 20:28:49 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192384

Powered by Google App Engine
This is Rietveld 408576698