Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 1026453002: Add a new test fast/encoding/char-decoding-invalid-trail.html (Closed)

Created:
5 years, 9 months ago by jungshik at Google
Modified:
5 years, 9 months ago
Reviewers:
jsbell
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add a new test fast/encoding/char-decoding-invalid-trail.html Mark it as Failure because it'll fail until we roll ICU to include https://codereview.chromium.org/984233002/ Also mark fast/encoding/char-decoding-truncated.html as requiring manual rebaseline for the same reason. BUG=450312, 430823 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192199

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -0 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +5 lines, -0 lines 0 comments Download
A LayoutTests/fast/encoding/char-decoding-invalid-trail.html View 1 chunk +56 lines, -0 lines 0 comments Download
A LayoutTests/fast/encoding/char-decoding-invalid-trail-expected.txt View 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
jungshik at Google
Can you take a look? I'll land this now (after review) and update TestExpectations after ...
5 years, 9 months ago (2015-03-19 18:57:14 UTC) #2
jsbell
lgtm
5 years, 9 months ago (2015-03-19 19:02:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026453002/1
5 years, 9 months ago (2015-03-19 19:13:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/39117) mac_blink_rel on tryserver.blink (JOB_FAILED, ...
5 years, 9 months ago (2015-03-19 19:15:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026453002/20001
5 years, 9 months ago (2015-03-19 20:45:04 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 22:02:33 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192199

Powered by Google App Engine
This is Rietveld 408576698