Update DisplayConfigurator to use c++11 style for-loops

Update DisplayConfigurator to use c++11 style for-loops

This is a formatting change, simplifying the existing code. No
functional change intended.

Also simplified how the DisplayState::selected_mode is populated when
parsing the displays.

BUG=none

Committed: https://crrev.com/53962b5c53a2962ca5b1bf12bb1214d841fd9041
Cr-Commit-Position: refs/heads/master@{#321416}

[dnicoara, 2015-03-19 18:26:24]

dnicoara@chromium.org changed reviewers:
+ oshima@chromium.org

[dnicoara, 2015-03-19 18:26:25]

As promised, this hopefully increases readability for the DisplayConfigurator
code.

[oshima, 2015-03-19 19:11:02]

lgtm with nits

https://codereview.chromium.org/1026443002/diff/1/ui/display/chromeos/display...
File ui/display/chromeos/display_configurator.cc (right):

https://codereview.chromium.org/1026443002/diff/1/ui/display/chromeos/display...
ui/display/chromeos/display_configurator.cc:344: selected_mode =
display.native_mode();
nit: return selected_mode ? selected_mode : display.native_mode();

https://codereview.chromium.org/1026443002/diff/1/ui/display/chromeos/display...
ui/display/chromeos/display_configurator.cc:364: for (auto external_mode :
external_display->display->modes()) {
const auto* (I'd prefer to have type here, if it fits in single one. If not,
please disregard)

[dnicoara, 2015-03-19 19:27:01]

https://codereview.chromium.org/1026443002/diff/1/ui/display/chromeos/display...
File ui/display/chromeos/display_configurator.cc (right):

https://codereview.chromium.org/1026443002/diff/1/ui/display/chromeos/display...
ui/display/chromeos/display_configurator.cc:344: selected_mode =
display.native_mode();
On 2015/03/19 19:11:01, oshima wrote:
> nit: return selected_mode ? selected_mode : display.native_mode();

Done.

https://codereview.chromium.org/1026443002/diff/1/ui/display/chromeos/display...
ui/display/chromeos/display_configurator.cc:364: for (auto external_mode :
external_display->display->modes()) {
On 2015/03/19 19:11:01, oshima wrote:
> const auto* (I'd prefer to have type here, if it fits in single one. If not,
> please disregard)

Replaced with const auto*

I would have liked the type as well, except it is just shy of fitting on the
line.

[dnicoara, 2015-03-19 19:27:10]

The CQ bit was checked by dnicoara@chromium.org

[dnicoara, 2015-03-19 19:27:11]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/1026443002/#ps20001
(title: ".")

[commit-bot: I haz the power, 2015-03-19 19:27:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1026443002/20001

[commit-bot: I haz the power, 2015-03-19 20:09:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-19 20:10:09]

Patchset 2 (id:??) landed as
https://crrev.com/53962b5c53a2962ca5b1bf12bb1214d841fd9041
Cr-Commit-Position: refs/heads/master@{#321416}