Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1026343004: Prevent leaks of cross context maps in the Oracle. (Closed)

Created:
5 years, 9 months ago by mvstanton
Modified:
5 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Prevent leaks of cross context maps in the Oracle. Some code in type-info.cc could allow a cross context map to be visible to crankshaft. Tighten up this code to be certain that only a JSFunction, an AllocationSite or a Symbol can be returned. R=verwaest@chromium.org BUG= Committed: https://crrev.com/821655fb5778141140a7d4b0151aede04fca522b Cr-Commit-Position: refs/heads/master@{#27417}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M src/type-info.cc View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
mvstanton
Hi Toon, thx for the pointer to this. PTAL, --Michael
5 years, 9 months ago (2015-03-24 14:13:21 UTC) #1
Toon Verwaest
lgtm
5 years, 9 months ago (2015-03-24 15:07:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026343004/1
5 years, 9 months ago (2015-03-24 15:09:02 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 15:37:19 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 15:37:32 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/821655fb5778141140a7d4b0151aede04fca522b
Cr-Commit-Position: refs/heads/master@{#27417}

Powered by Google App Engine
This is Rietveld 408576698