Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1026283004: fix disposal of phantom handles in GlobalValueMap (Closed)

Created:
5 years, 9 months ago by dcarney
Modified:
5 years, 9 months ago
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

fix disposal of phantom handles in GlobalValueMap additionally, add a drive by fix to WeakCallbackInfo R=jochen@chromium.org, erikcorry@chromium.org BUG= Committed: https://crrev.com/adeb82ef236158f39d875592aed7ca43b11e9671 Cr-Commit-Position: refs/heads/master@{#27407}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -10 lines) Patch
M include/v8.h View 1 5 chunks +32 lines, -8 lines 0 comments Download
M include/v8-util.h View 3 chunks +7 lines, -2 lines 0 comments Download
M src/api.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +118 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dcarney
ptal
5 years, 9 months ago (2015-03-24 11:29:42 UTC) #2
Erik Corry
https://codereview.chromium.org/1026283004/diff/1/test/cctest/test-api.cc File test/cctest/test-api.cc (right): https://codereview.chromium.org/1026283004/diff/1/test/cctest/test-api.cc#newcode3244 test/cctest/test-api.cc:3244: CHECK_EQ(IntKeyToVoidPointer(key), info.GetInternalField1()); The test only uses the deprecated version, ...
5 years, 9 months ago (2015-03-24 12:16:20 UTC) #4
jochen (gone - plz use gerrit)
lgtm with test updated
5 years, 9 months ago (2015-03-24 12:19:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026283004/20001
5 years, 9 months ago (2015-03-24 12:33:38 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-24 13:22:12 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 13:22:22 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/adeb82ef236158f39d875592aed7ca43b11e9671
Cr-Commit-Position: refs/heads/master@{#27407}

Powered by Google App Engine
This is Rietveld 408576698