Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1026253002: Rename FrameDestructionObserver to LocalFrameLifecycleObserver. (Closed)

Created:
5 years, 9 months ago by sof
Modified:
5 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, groby+blinkspell_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rename FrameDestructionObserver to LocalFrameLifecycleObserver. Renamed so as to be consistent with the naming of other lifecycle observers. R=haraken BUG=462949 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192418

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -114 lines) Patch
M Source/core/core.gypi View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/editing/Editor.h View 1 chunk +0 lines, -1 line 0 comments Download
D Source/core/frame/FrameDestructionObserver.h View 1 chunk +0 lines, -58 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.h View 1 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/frame/LocalFrame.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/LocalFrame.cpp View 1 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/frame/LocalFrameLifecycleNotifier.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/frame/LocalFrameLifecycleNotifier.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/frame/LocalFrameLifecycleObserver.h View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/permissions/PermissionController.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/permissions/PermissionController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/plugins/DOMMimeType.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/plugins/DOMMimeType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/plugins/DOMPlugin.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/plugins/DOMPlugin.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/presentation/PresentationController.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/presentation/PresentationController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientationController.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientationController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/storage/StorageArea.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/storage/StorageArea.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/web/WebPluginContainerImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebPluginContainerImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
please take a look. If some of the observers should eventually be able to observe ...
5 years, 9 months ago (2015-03-24 07:09:00 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-03-24 07:59:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026253002/20001
5 years, 9 months ago (2015-03-24 08:07:49 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 08:18:08 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192418

Powered by Google App Engine
This is Rietveld 408576698