Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1866)

Unified Diff: tests/minnacl/nacl.scons

Issue 1026243002: Add Subzero to test scripts. (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master
Patch Set: Code review changes Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pnacl/scripts/llvm-test.py ('k') | tests/spec2k/Makefile.common » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/minnacl/nacl.scons
diff --git a/tests/minnacl/nacl.scons b/tests/minnacl/nacl.scons
index 042d742ff72b737a261d2a79133433ef47ed7091..23d45a2436e3e40529caed21d30663def6e0ed56 100644
--- a/tests/minnacl/nacl.scons
+++ b/tests/minnacl/nacl.scons
@@ -39,6 +39,11 @@ env.Replace(TRANSLATEFLAGS=['-nostdlib'])
# the sandboxed translator.
if env.Bit('use_sandboxed_translator'):
Return()
+# TODO(stichnot,jvoung): For this special minimal-code test (see comment above),
+# linking the Subzero generated ELF file results in a nexe that fails
+# validation. https://code.google.com/p/nativeclient/issues/detail?id=4134
+if env.Bit('use_sz'):
+ Return()
test_prog = env.GetTranslatedNexe(test_prog)
is_broken = not env.Bit('nacl_static_link')
« no previous file with comments | « pnacl/scripts/llvm-test.py ('k') | tests/spec2k/Makefile.common » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698