cc/scheduler/begin_frame_source.h - Issue 1026233002: cc: Making BeginFrameSources support multiple BeginFrameObservers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/scheduler/begin_frame_source.h

Issue 1026233002: cc: Making BeginFrameSources support multiple BeginFrameObservers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding tests. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/scheduler/begin_frame_source.h

diff --git a/cc/scheduler/begin_frame_source.h b/cc/scheduler/begin_frame_source.h

index f6f1a789da7bb5770d8e4c5ae960de1b60ab14d5..fe6c5101ce35506af96b42d98d7b103cbf7b3a3b 100644

--- a/cc/scheduler/begin_frame_source.h

+++ b/cc/scheduler/begin_frame_source.h

@@ -136,7 +136,7 @@ class CC_EXPORT BeginFrameSource {

// in their own AsValueInto implementation.

class CC_EXPORT BeginFrameSourceBase : public BeginFrameSource {

public:

- ~BeginFrameSourceBase() override {}

+ ~BeginFrameSourceBase() override;

// BeginFrameSource

bool NeedsBeginFrames() const final;

@@ -161,7 +161,9 @@ class CC_EXPORT BeginFrameSourceBase : public BeginFrameSource {

// needs_begin_frames change.

virtual void OnNeedsBeginFramesChange(bool needs_begin_frames) {}

- BeginFrameObserver* observer_;

+ base::ObserverList<const BeginFrameObserver>::Iterator

+ getConstObserverListIterator() const;

+ base::ObserverList<BeginFrameObserver> observer_list_;

bool needs_begin_frames_;

private:

« no previous file with comments | « no previous file | cc/scheduler/begin_frame_source.cc » ('j') | cc/scheduler/begin_frame_source_unittest.cc » ('J')