Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 102623003: [v8-dev] ARM: Optimize truncating division and fix sim (Closed)

Created:
7 years ago by m.m.capewell
Modified:
6 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

ARM: Optimize truncating division and fix sim Optimize code generated for DivI Lithium instruction when handling division where the result is int32. Also, fix the ARM simulator to give the correct answer for kMinInt / -1. TEST=Division tests added to test-assembler-arm.cc BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18445

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -2 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/arm/simulator-arm.cc View 1 chunk +5 lines, -1 line 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 chunk +66 lines, -0 lines 3 comments Download

Messages

Total messages: 6 (0 generated)
m.m.capewell
7 years ago (2013-12-10 14:37:39 UTC) #1
m.m.capewell
This patch reintroduces an optimization for integer division when all uses subsequently truncate to int32. ...
7 years ago (2013-12-10 14:59:40 UTC) #2
ulan
LGTM https://codereview.chromium.org/102623003/diff/1/test/cctest/test-assembler-arm.cc File test/cctest/test-assembler-arm.cc (right): https://codereview.chromium.org/102623003/diff/1/test/cctest/test-assembler-arm.cc#newcode1486 test/cctest/test-assembler-arm.cc:1486: Code::cast(code)->Print(); Is this leftover from debug?
7 years ago (2013-12-11 13:57:10 UTC) #3
vincent.belliard.fr
https://codereview.chromium.org/102623003/diff/1/test/cctest/test-assembler-arm.cc File test/cctest/test-assembler-arm.cc (right): https://codereview.chromium.org/102623003/diff/1/test/cctest/test-assembler-arm.cc#newcode1486 test/cctest/test-assembler-arm.cc:1486: Code::cast(code)->Print(); This is done in almost all the arm ...
7 years ago (2013-12-11 14:20:29 UTC) #4
ulan
https://codereview.chromium.org/102623003/diff/1/test/cctest/test-assembler-arm.cc File test/cctest/test-assembler-arm.cc (right): https://codereview.chromium.org/102623003/diff/1/test/cctest/test-assembler-arm.cc#newcode1486 test/cctest/test-assembler-arm.cc:1486: Code::cast(code)->Print(); On 2013/12/11 14:20:29, vincent.belliard.fr wrote: > This is ...
7 years ago (2013-12-11 14:40:07 UTC) #5
m.m.capewell
6 years, 11 months ago (2014-01-02 16:36:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r18445 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698