Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1026223003: Fix the documentation of ExtensionRegistryObserver::OnExtensionUnloaded. (Closed)

Created:
5 years, 9 months ago by pneubeck (no reviews)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the documentation of ExtensionRegistryObserver::OnExtensionUnloaded. The documentation didn't match the implementation, e.g. of ExtensionService::TrackTerminatedExtension . Committed: https://crrev.com/ca65e0ad7834d79d04f8d8d0e846c040a1846145 Cr-Commit-Position: refs/heads/master@{#322030}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M extensions/browser/extension_registry_observer.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
pneubeck (no reviews)
ptal
5 years, 9 months ago (2015-03-24 09:35:35 UTC) #4
Ken Rockot(use gerrit already)
lgtm
5 years, 9 months ago (2015-03-24 16:51:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026223003/40001
5 years, 9 months ago (2015-03-24 17:02:12 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 9 months ago (2015-03-24 18:15:43 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 18:16:22 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca65e0ad7834d79d04f8d8d0e846c040a1846145
Cr-Commit-Position: refs/heads/master@{#322030}

Powered by Google App Engine
This is Rietveld 408576698