Instrumented libraries: add a base.isolate entry for prebuilt libs.

Instrumented libraries: add a base.isolate entry for prebuilt libs.

Also, move instrumented-libraries-related stuff to a separate
.isolate file.

BUG=462636
TBR=maruel@chromium.org

Committed: https://crrev.com/528c36c06b20a69e9757d8e4363629efd2372b61
Cr-Commit-Position: refs/heads/master@{#321998}

[earthdok, 2015-03-24 12:12:17]

The CQ bit was checked by earthdok@chromium.org

[commit-bot: I haz the power, 2015-03-24 12:12:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1026183003/1

[commit-bot: I haz the power, 2015-03-24 12:40:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-24 12:40:19]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[earthdok, 2015-03-24 12:48:46]

The CQ bit was checked by earthdok@chromium.org

[commit-bot: I haz the power, 2015-03-24 12:49:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1026183003/20001

[M-A Ruel, 2015-03-24 13:09:46]

The CQ bit was unchecked by maruel@chromium.org

[M-A Ruel, 2015-03-24 13:10:10]

What's instrumented libraries?
I stopped the CQ because you forgot to update android's script.

[earthdok, 2015-03-24 13:19:43]

On 2015/03/24 13:10:10, M-A Ruel wrote:
> What's instrumented libraries?

This refers to third-party dependencies which would normally be installed in the
system (e.g. the gnome stack). In "instrumented libraries" mode we rebuild them
with ASan/MSan/TSan enabled and supply the resulting binaries to
ASan/MSan/TSan-instrumented Chromium.

"Prebuilt" refers to a new mode where the binaries would be downloaded from GCS,
whereas currently every builder builds them from source.

> I stopped the CQ because you forgot to update android's script.

Fixed, thanks. Waiting for approval.

[M-A Ruel, 2015-03-24 13:22:51]

https://codereview.chromium.org/1026183003/diff/40001/base/base.isolate
File base/base.isolate (right):

https://codereview.chromium.org/1026183003/diff/40001/base/base.isolate#newco...
base/base.isolate:26: ['use_prebuilt_instrumented_libraries==1', {
I'm not sure it is the right place. Are these files "built" when building target
base? Same for lines 19-25.

[earthdok, 2015-03-24 13:29:29]

https://codereview.chromium.org/1026183003/diff/40001/base/base.isolate
File base/base.isolate (right):

https://codereview.chromium.org/1026183003/diff/40001/base/base.isolate#newco...
base/base.isolate:26: ['use_prebuilt_instrumented_libraries==1', {
On 2015/03/24 13:22:51, M-A Ruel wrote:
> I'm not sure it is the right place. Are these files "built" when building
target
> base? Same for lines 19-25.

The files are produced by
third_party/instrumented_libraries/instrumented_libraries.gyp:(prebuilt_)instrumented_libraries,
which is a global dependency.

Actually looks like this belongs in
third_party/instrumented_libraries/instrumented_libraries.isolate? I mindlessly
added this to base.isolate because that's where other global sanitizer-related
dependencies where handled. :(

[M-A Ruel, 2015-03-24 13:31:12]

https://codereview.chromium.org/1026183003/diff/40001/base/base.isolate
File base/base.isolate (right):

https://codereview.chromium.org/1026183003/diff/40001/base/base.isolate#newco...
base/base.isolate:26: ['use_prebuilt_instrumented_libraries==1', {
On 2015/03/24 13:29:29, earthdok wrote:
> On 2015/03/24 13:22:51, M-A Ruel wrote:
> > I'm not sure it is the right place. Are these files "built" when building
> target
> > base? Same for lines 19-25.
> 
> The files are produced by
>
third_party/instrumented_libraries/instrumented_libraries.gyp:(prebuilt_)instrumented_libraries,
> which is a global dependency.
> 
> Actually looks like this belongs in
> third_party/instrumented_libraries/instrumented_libraries.isolate? I
mindlessly
> added this to base.isolate because that's where other global sanitizer-related
> dependencies where handled. :(

It is preferable to have the .isolate aside the .gyp that defines the target
that generates the files. So I'd like instrumented_libraries to be migrated
along.

Thanks

[earthdok, 2015-03-24 13:42:11]

https://codereview.chromium.org/1026183003/diff/40001/base/base.isolate
File base/base.isolate (right):

https://codereview.chromium.org/1026183003/diff/40001/base/base.isolate#newco...
base/base.isolate:26: ['use_prebuilt_instrumented_libraries==1', {
On 2015/03/24 13:31:12, M-A Ruel wrote:
> On 2015/03/24 13:29:29, earthdok wrote:
> > On 2015/03/24 13:22:51, M-A Ruel wrote:
> > > I'm not sure it is the right place. Are these files "built" when building
> > target
> > > base? Same for lines 19-25.
> > 
> > The files are produced by
> >
>
third_party/instrumented_libraries/instrumented_libraries.gyp:(prebuilt_)instrumented_libraries,
> > which is a global dependency.
> > 
> > Actually looks like this belongs in
> > third_party/instrumented_libraries/instrumented_libraries.isolate? I
> mindlessly
> > added this to base.isolate because that's where other global
sanitizer-related
> > dependencies where handled. :(
> 
> It is preferable to have the .isolate aside the .gyp that defines the target
> that generates the files. So I'd like instrumented_libraries to be migrated
> along.
> 
> Thanks

Done. I should also move lines 12-17 to a separate file. I'll have to do it in a
separate CL because libc++ is located in buildtools/.

Is there a better way of introducing a global dependency other than through
base.isolate?

[M-A Ruel, 2015-03-24 13:52:09]

lgtm

https://codereview.chromium.org/1026183003/diff/40001/base/base.isolate
File base/base.isolate (right):

https://codereview.chromium.org/1026183003/diff/40001/base/base.isolate#newco...
base/base.isolate:26: ['use_prebuilt_instrumented_libraries==1', {
On 2015/03/24 13:42:11, earthdok wrote:
> Done. I should also move lines 12-17 to a separate file. I'll have to do it in
a
> separate CL because libc++ is located in buildtools/.

Ok


> Is there a better way of introducing a global dependency other than through
> base.isolate?

Patchset #4 uses the right way; the .isolate is aside the .gyp that defines the
target that generate the relevant files. base.isolate is more or less the
defacto global includes.

[earthdok, 2015-03-24 13:57:17]

The CQ bit was checked by earthdok@chromium.org

[commit-bot: I haz the power, 2015-03-24 13:57:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1026183003/60001

[commit-bot: I haz the power, 2015-03-24 15:05:56]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-03-24 15:06:21]

Patchset 4 (id:??) landed as
https://crrev.com/528c36c06b20a69e9757d8e4363629efd2372b61
Cr-Commit-Position: refs/heads/master@{#321998}