add initWebComponents

add initWebComponents

R=sigmund@google.com

Committed: https://github.com/dart-lang/web-components/commit/1a01a5296406b6f05924687f56c52a813ca60bbc

[jakemac, 2015-03-23 21:53:03]

jakemac@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2015-03-23 22:16:26]

awesome Jake, just one comment about the the mirror initializer. Maybe we could
add a test with some inlined Dart code to test it out.

https://codereview.chromium.org/1026153002/diff/20001/lib/src/mirror_initiali...
File lib/src/mirror_initializer.dart (right):

https://codereview.chromium.org/1026153002/diff/20001/lib/src/mirror_initiali...
lib/src/mirror_initializer.dart:50: 'See http://goo.gl/5HPeuP#polymer_44 for
more details.');
we might want to relabel this warning in the future, to use the #web_components
prefix. I'm ok doing that on a separate CL, since this package doesn't have any
messages yet.

https://codereview.chromium.org/1026153002/diff/20001/lib/src/mirror_initiali...
lib/src/mirror_initializer.dart:139: (info) => _packageUrlExists(info) ?
info.packageUrl : info.resolvedUrl);
I think that to support inline Dart script tags, we need to replace
`info.resolvedUrl` with `info.importUrl` here.

[jakemac, 2015-03-23 22:32:41]

https://codereview.chromium.org/1026153002/diff/20001/lib/src/mirror_initiali...
File lib/src/mirror_initializer.dart (right):

https://codereview.chromium.org/1026153002/diff/20001/lib/src/mirror_initiali...
lib/src/mirror_initializer.dart:50: 'See http://goo.gl/5HPeuP#polymer_44 for
more details.');
On 2015/03/23 22:16:26, Siggi Cherem (dart-lang) wrote:
> we might want to relabel this warning in the future, to use the
#web_components
> prefix. I'm ok doing that on a separate CL, since this package doesn't have
any
> messages yet.

Acknowledged.

https://codereview.chromium.org/1026153002/diff/20001/lib/src/mirror_initiali...
lib/src/mirror_initializer.dart:139: (info) => _packageUrlExists(info) ?
info.packageUrl : info.resolvedUrl);
On 2015/03/23 22:16:26, Siggi Cherem (dart-lang) wrote:
> I think that to support inline Dart script tags, we need to replace
> `info.resolvedUrl` with `info.importUrl` here.

worked on this together, and stripped out some more unused code.

[Siggi Cherem (dart-lang), 2015-03-23 22:37:33]

lgtm, beautiful :)

[jakemac, 2015-03-23 22:37:53]

Committed patchset #3 (id:40001) manually as
1a01a5296406b6f05924687f56c52a813ca60bbc (presubmit successful).