Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1026123002: Change DataReductionProxy browser_tests to use dataReductionProxy API. (Closed)

Created:
5 years, 9 months ago by Not at Google. Contact bengr
Modified:
5 years, 9 months ago
Reviewers:
bengr
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change DataReductionProxy browser_tests to use dataReductionProxy API. The extension was changed to use preferences API rather than direct settings API. This cl updates the test to use the same API. Committed: https://crrev.com/9990fe47e3d3db3b245d480e17f37e615ded1040 Cr-Commit-Position: refs/heads/master@{#321840}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M chrome/test/data/extensions/api_test/preference/data_reduction_proxy/test.js View 4 chunks +14 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Not at Google. Contact bengr
5 years, 9 months ago (2015-03-23 18:22:27 UTC) #2
bengr
lgtm
5 years, 9 months ago (2015-03-23 18:51:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026123002/1
5 years, 9 months ago (2015-03-23 18:53:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-23 20:49:49 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 20:50:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9990fe47e3d3db3b245d480e17f37e615ded1040
Cr-Commit-Position: refs/heads/master@{#321840}

Powered by Google App Engine
This is Rietveld 408576698