Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: chrome/browser/web_applications/web_app_win.h

Issue 1026113003: Don't send a SHChangeNotify for creating an app icon when creating a shortcut. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix nits Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/web_applications/web_app_win.h
diff --git a/chrome/browser/web_applications/web_app_win.h b/chrome/browser/web_applications/web_app_win.h
index b86f91a50221670a926894bbcbc33f2ba2eb2e26..7dba046ff9ba1c3d59b3bf8e6dabec376dc78eea 100644
--- a/chrome/browser/web_applications/web_app_win.h
+++ b/chrome/browser/web_applications/web_app_win.h
@@ -37,8 +37,15 @@ void UpdateRelaunchDetailsForApp(Profile* profile,
namespace internals {
+// Saves |image| to |icon_file| if the file is outdated. Returns true if
+// icon_file is up to date or successfully updated.
+// If |refresh_shell_icon_cache| is true, the shell's icon cache will be
+// refreshed, ensuring the correct icon is displayed, but causing a flicker.
+// Refreshing the icon cache is not necessary on shortcut creation as the shell
+// will be notified when the shortcut is created.
bool CheckAndSaveIcon(const base::FilePath& icon_file,
- const gfx::ImageFamily& image);
+ const gfx::ImageFamily& image,
+ bool refresh_shell_icon_cache);
base::FilePath GetIconFilePath(const base::FilePath& web_app_path,
const base::string16& title);
« no previous file with comments | « chrome/browser/web_applications/update_shortcut_worker_win.cc ('k') | chrome/browser/web_applications/web_app_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698