chrome/browser/web_applications/update_shortcut_worker_win.cc - Issue 1026113003: Don't send a SHChangeNotify for creating an app icon when creating a shortcut.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/web_applications/update_shortcut_worker_win.cc

Issue 1026113003: Don't send a SHChangeNotify for creating an app icon when creating a shortcut. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/web_applications/update_shortcut_worker_win.cc

diff --git a/chrome/browser/web_applications/update_shortcut_worker_win.cc b/chrome/browser/web_applications/update_shortcut_worker_win.cc

index a1f59858d752254153acf3c2854d2da643a3759e..690ffddbce1e60788898c438336395568fe08f52 100644

--- a/chrome/browser/web_applications/update_shortcut_worker_win.cc

+++ b/chrome/browser/web_applications/update_shortcut_worker_win.cc

@@ -192,7 +192,8 @@ void UpdateShortcutWorker::UpdateShortcutsOnFileThread() {

base::FilePath icon_file =

web_app::internals::GetIconFilePath(web_app_path, shortcut_info_.title);

- web_app::internals::CheckAndSaveIcon(icon_file, shortcut_info_.favicon);

+ web_app::internals::CheckAndSaveIcon(icon_file, shortcut_info_.favicon,

+ true);

// Update existing shortcuts' description, icon and app id.

CheckExistingShortcuts();

« no previous file with comments | « no previous file | chrome/browser/web_applications/web_app_win.h » ('j') | chrome/browser/web_applications/web_app_win.h » ('J')