chrome/browser/web_applications/web_app_win.h - Issue 1026113003: Don't send a SHChangeNotify for creating an app icon when creating a shortcut.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/web_applications/web_app_win.h

Issue 1026113003: Don't send a SHChangeNotify for creating an app icon when creating a shortcut. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/web_applications/update_shortcut_worker_win.cc ('k') | chrome/browser/web_applications/web_app_win.cc » ('j') | chrome/browser/web_applications/web_app_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/web_applications/web_app_win.h

diff --git a/chrome/browser/web_applications/web_app_win.h b/chrome/browser/web_applications/web_app_win.h

index b86f91a50221670a926894bbcbc33f2ba2eb2e26..5b914e8c710d9309468661925803e2029ecd8fa8 100644

--- a/chrome/browser/web_applications/web_app_win.h

+++ b/chrome/browser/web_applications/web_app_win.h

@@ -38,7 +38,8 @@ void UpdateRelaunchDetailsForApp(Profile* profile,

namespace internals {

bool CheckAndSaveIcon(const base::FilePath& icon_file,

- const gfx::ImageFamily& image);

+ const gfx::ImageFamily& image,

+ bool is_shortcut_creation);

Matt Giuca 2015/03/25 03:31:19 Call this "do_shchangenotify" (and invert the trut

calamity 2015/03/25 04:37:23 Changed it to refresh_shell_icon_cache.

base::FilePath GetIconFilePath(const base::FilePath& web_app_path,

const base::string16& title);