Don't send a SHChangeNotify for creating an app icon when creating a shortcut.

chrome/browser/web_applications/web_app_win.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_WEB_APPLICATIONS_WEB_APP_WIN_H_
 #define CHROME_BROWSER_WEB_APPLICATIONS_WEB_APP_WIN_H_
 
 #include "base/files/file_path.h"
 #include "chrome/browser/web_applications/web_app.h"
 
@@ skipping 19 matching lines @@
                                          const ShortcutInfo& shortcut_info);
 
 // Update the relaunch details for the given app's window, making the taskbar
 // group's "Pin to the taskbar" button function correctly.
 void UpdateRelaunchDetailsForApp(Profile* profile,
                                  const extensions::Extension* extension,
                                  HWND hwnd);
 
 namespace internals {
 
+// Saves |image| to |icon_file| if the file is outdated and refresh shell's icon
+// cache to ensure correct icon is displayed. Returns true if icon_file is up to
+// date or successfully updated. If |refresh_shell_icon_cache| is true, the
+// shell's icon cache will be refreshed, causing a flicker. Refreshing the icon

[Matt Giuca, 2015/03/25 06:20:52]

"and refresh shell's icon cache to ensure correct icon is displayed" --- weird
to have that in the opening sentence when it is conditional.

Why not delete that clause of the first sentence, and elaborate here where you
talk about the parameter:
"If |refresh_shell_icon_cache| is true, the shell's icon cache will be
refreshed, ensuring the correct icon is displayed, but causing a flicker."

[calamity, 2015/03/26 04:09:52]

Done.

+// cache is not necessary on shortcut creation as the shell wil be notified when

[Matt Giuca, 2015/03/25 06:20:53]

nit: wil

[calamity, 2015/03/26 04:09:52]

Done.

+// the shortcut is created.
 bool CheckAndSaveIcon(const base::FilePath& icon_file,
-                      const gfx::ImageFamily& image);
+                      const gfx::ImageFamily& image,
+                      bool refresh_shell_icon_cache);
 
 base::FilePath GetIconFilePath(const base::FilePath& web_app_path,
                                const base::string16& title);
 
 }  // namespace internals
 
 }  // namespace web_app
 
 #endif  // CHROME_BROWSER_WEB_APPLICATIONS_WEB_APP_WIN_H_