Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1254)

Unified Diff: pkg/analyzer/lib/src/generated/engine.dart

Issue 1026093002: Fix hints in the analyzer package. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/generated/engine.dart
diff --git a/pkg/analyzer/lib/src/generated/engine.dart b/pkg/analyzer/lib/src/generated/engine.dart
index 73728a9588cfa51e357cf89ce2dff2032c5c933f..bfb1f09b5d11d81961cf154ad5231eeea4ba40ef 100644
--- a/pkg/analyzer/lib/src/generated/engine.dart
+++ b/pkg/analyzer/lib/src/generated/engine.dart
@@ -1758,7 +1758,7 @@ class AnalysisContextImpl implements InternalAnalysisContext {
} else if (sourceEntry is DartEntry) {
try {
return _getDartParseData(source, sourceEntry, DartEntry.SOURCE_KIND);
- } on AnalysisException catch (exception) {
+ } on AnalysisException {
return SourceKind.UNKNOWN;
}
}
@@ -1919,7 +1919,7 @@ class AnalysisContextImpl implements InternalAnalysisContext {
}
}
}
- } on _ElementByIdFinderException catch (e) {
+ } on _ElementByIdFinderException {
return finder.result;
}
return null;
@@ -6810,7 +6810,7 @@ abstract class AnalysisTask {
AnalysisEngine.instance.instrumentationService.logAnalysisTask(
contextName, taskDescription);
internalPerform();
- } on AnalysisException catch (exception) {
+ } on AnalysisException {
rethrow;
} catch (exception, stackTrace) {
throw new AnalysisException(
@@ -9474,7 +9474,7 @@ class IncrementalAnalysisTask extends AnalysisTask {
TypeProvider get typeProvider {
try {
return context.typeProvider;
- } on AnalysisException catch (exception) {
+ } on AnalysisException {
return null;
}
}
@@ -10160,7 +10160,7 @@ class ParseHtmlTask_getLibrarySources extends ht.RecursiveXmlVisitor<Object> {
if (_task.context.exists(librarySource)) {
libraries.add(librarySource);
}
- } on FormatException catch (e) {
+ } on FormatException {
// ignored - invalid URI reported during resolution phase
}
}
« no previous file with comments | « pkg/analyzer/lib/src/generated/constant.dart ('k') | pkg/analyzer/lib/src/generated/incremental_resolver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698