[Icons NTP] Add a flag to enable large icons on the NTP.

[Icons NTP] Add a flag to enable large icons on the NTP.

BUG=467712
Committed: https://crrev.com/4e5b2bba9ab61d1c8ad282873b822379b6045f2e
Cr-Commit-Position: refs/heads/master@{#322392}

[beaudoin, 2015-03-25 01:47:48]

beaudoin@chromium.org changed reviewers:
+ huangs@chromium.org

[huangs, 2015-03-25 06:00:35]

Wondering about naming, so we're going with plural "icons"?  If so then I should
change the field trail to IconsNTP/Enabled for consistency.

I presume this is to add the flags, and the hook to enable the feature will be
another CL?

[chromium-reviews, 2015-03-25 12:32:12]

I'll use your naming.

On 25 March 2015 at 02:00, <huangs@chromium.org> wrote:

> Wondering about naming, so we're going with plural "icons"?  If so then I
> should
> change the field trail to IconsNTP/Enabled for consistency.
>
> I presume this is to add the flags, and the hook to enable the feature
> will be
> another CL?
>
> https://chromiumcodereview.appspot.com/1026053003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[beaudoin, 2015-03-25 12:47:37]

PTAL

[huangs, 2015-03-25 13:51:21]

lgtm

[beaudoin, 2015-03-25 15:11:53]

The CQ bit was checked by beaudoin@chromium.org

[commit-bot: I haz the power, 2015-03-25 15:12:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1026053003/20001

[commit-bot: I haz the power, 2015-03-25 16:02:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-25 16:02:03]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[beaudoin, 2015-03-25 19:20:13]

The CQ bit was checked by beaudoin@chromium.org

[beaudoin, 2015-03-25 19:20:14]

The patchset sent to the CQ was uploaded after l-g-t-m from huangs@chromium.org
Link to the patchset: https://codereview.chromium.org/1026053003/#ps40001
(title: "Added flags to histograms.xml")

[commit-bot: I haz the power, 2015-03-25 19:21:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1026053003/40001

[commit-bot: I haz the power, 2015-03-25 19:30:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-25 19:30:39]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[beaudoin, 2015-03-25 19:34:34]

beaudoin@chromium.org changed reviewers:
+ jwd@google.com

[beaudoin, 2015-03-25 19:34:34]

beaudoin@chromium.org changed required reviewers:
+ jwd@google.com

[beaudoin, 2015-03-25 19:34:59]

R+jwd for histograms.xml

[jwd, 2015-03-26 13:54:38]

jwd@chromium.org changed reviewers:
+ jwd@chromium.org

[jwd, 2015-03-26 13:54:39]

lgtm

[beaudoin, 2015-03-26 13:56:17]

beaudoin@chromium.org changed reviewers:
- jwd@google.com

[beaudoin, 2015-03-26 13:56:17]

beaudoin@chromium.org changed required reviewers:
- jwd@google.com

[beaudoin, 2015-03-26 13:56:28]

The CQ bit was checked by beaudoin@chromium.org

[commit-bot: I haz the power, 2015-03-26 13:56:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1026053003/40001

[commit-bot: I haz the power, 2015-03-26 14:01:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-26 14:01:50]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[beaudoin, 2015-03-26 15:06:24]

The CQ bit was checked by beaudoin@chromium.org

[commit-bot: I haz the power, 2015-03-26 15:06:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1026053003/40001

[beaudoin, 2015-03-26 15:07:04]

The CQ bit was checked by beaudoin@chromium.org

[beaudoin, 2015-03-26 15:07:05]

The patchset sent to the CQ was uploaded after l-g-t-m from huangs@chromium.org,
jwd@chromium.org
Link to the patchset: https://codereview.chromium.org/1026053003/#ps60001
(title: "Rebased")

[commit-bot: I haz the power, 2015-03-26 15:07:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1026053003/60001

[commit-bot: I haz the power, 2015-03-26 16:07:05]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-03-26 16:07:47]

Patchset 4 (id:??) landed as
https://crrev.com/4e5b2bba9ab61d1c8ad282873b822379b6045f2e
Cr-Commit-Position: refs/heads/master@{#322392}