Issue 102603014: FileAPI: Fix memory leak in WebFileSystemImpl (won't commit)

Issue 102603014: FileAPI: Fix memory leak in WebFileSystemImpl (won't commit) (Closed)

Created:
7 years ago by nhiroki

Modified:
6 years, 8 months ago

Reviewers:
kinuko

CC:
chromium-reviews, tzik, jam, nhiroki, joi+watch-content_chromium.org, darin-cc_chromium.org, timurrrr+watch_chromium.org, kinuko+watch, glider+watch_chromium.org, bruening+watch_chromium.org, hashimoto

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

FileAPI: Fix memory leak in WebFileSystemImpl # This has already been fixed in the different patch. WaitableEvent held by WaitableCallbackResults seems leaky. BUG=293058 TEST=should pass all existing tests (no behavioral changes)

Patch Set 1 : #

Patch Set 2 : rebase #

Patch Set 3 : fix #

Total comments: 3

Patch Set 4 : fix argument order #

Patch Set 5 : clean up #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -78 lines)			Patch
	M	content/child/fileapi/webfilesystem_impl.cc	View	1 2 3 4	11 chunks	+75 lines, -60 lines	0 comments	Download
	M	tools/valgrind/memcheck/suppressions.txt	View	1	1 chunk	+0 lines, -18 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

nhiroki

https://codereview.chromium.org/102603014/diff/60001/content/child/fileapi/webfilesystem_impl.cc File content/child/fileapi/webfilesystem_impl.cc (right): https://codereview.chromium.org/102603014/diff/60001/content/child/fileapi/webfilesystem_impl.cc#newcode348 content/child/fileapi/webfilesystem_impl.cc:348: waitable_results.Pass()); Hmm... |waitable_results| can be passed before calling get(). ...

6 years, 9 months ago (2014-03-05 15:16:07 UTC) #2

kinuko

lgtm if you fix scoped ptr ref ordering issue. https://codereview.chromium.org/102603014/diff/60001/content/child/fileapi/webfilesystem_impl.cc File content/child/fileapi/webfilesystem_impl.cc (left): https://codereview.chromium.org/102603014/diff/60001/content/child/fileapi/webfilesystem_impl.cc#oldcode68 content/child/fileapi/webfilesystem_impl.cc:68: ...

6 years, 9 months ago (2014-03-05 15:23:32 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/102603014/140001

6 years, 9 months ago (2014-03-06 12:54:49 UTC) #5

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 9 months ago (2014-03-06 12:56:27 UTC) #6

commit-bot: I haz the power

6 years, 9 months ago (2014-03-06 12:56:28 UTC) #7

Try jobs failed on following builders: mac_chromium_compile_dbg,
mac_chromium_rel

Expand Messages | Collapse Messages