Update Panel mininimize/restore button on strip and expansion state change.

chrome/browser/ui/panels/panel_browser_frame_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/panel_browser_frame_view.h"
 
 #include <algorithm>
 
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/themes/theme_service.h"
@@ skipping 294 matching lines @@
 
   const ButtonResources& restore_button_resources =
       GetRestoreButtonResources();
   restore_button_ = new views::ImageButton(this);
   restore_button_->SetImage(views::CustomButton::BS_NORMAL,
                             restore_button_resources.normal_image);
   restore_button_->SetImage(views::CustomButton::BS_HOT,
                             restore_button_resources.hover_image);
   restore_button_->SetTooltipText(restore_button_resources.tooltip_text);
   restore_button_->SetAccessibleName(restore_button_resources.tooltip_text);
+  restore_button_->SetVisible(false);  // only visible when panel is minimized
   AddChildView(restore_button_);
 
   title_icon_ = new TabIconView(this);
   title_icon_->set_is_light(true);
   AddChildView(title_icon_);
   title_icon_->Update();
 
   title_label_ = new views::Label(GetTitleText());
   title_label_->SetHorizontalAlignment(views::Label::ALIGN_LEFT);
   title_label_->SetAutoColorReadabilityEnabled(false);
@@ skipping 133 matching lines @@
 gfx::Size PanelBrowserFrameView::GetMaximumSize() {
   return panel_browser_view_->panel()->max_size();
 }
 
 void PanelBrowserFrameView::Layout() {
   Panel* panel = panel_browser_view_->panel();
   PanelStrip* panel_strip = panel->panel_strip();
   if (!panel_strip)
     return;
 
-  // Check if the width is only enough to show only the icon, or both icon
-  // and title. Hide corresponding controls accordingly.
-  // TODO(aburago) Make sure the close button is always visible even if the
-  // panel is too narrow.
-  bool show_close_button = true;
-  bool show_title_label = true;
-  bool show_restore_button = panel->CanRestore();
-  bool show_minimize_button = panel->CanMinimize();
-
-  close_button_->SetVisible(show_close_button);
-  minimize_button_->SetVisible(show_minimize_button);
-  restore_button_->SetVisible(show_restore_button);
-  title_label_->SetVisible(show_title_label);
-
   // Layout the close button.
   int right = width();
-  if (show_close_button) {
-    gfx::Size close_button_size = close_button_->GetPreferredSize();
-    close_button_->SetBounds(
-        width() - NonClientBorderThickness() - kCloseButtonAndBorderSpacing -
-            close_button_size.width(),
-        (NonClientTopBorderHeight() - close_button_size.height()) / 2,
-        close_button_size.width(),
-        close_button_size.height());
-    right = close_button_->x();
-  }
+  gfx::Size close_button_size = close_button_->GetPreferredSize();
+  close_button_->SetBounds(
+      width() - NonClientBorderThickness() - kCloseButtonAndBorderSpacing -
+      close_button_size.width(),
+      (NonClientTopBorderHeight() - close_button_size.height()) / 2,
+      close_button_size.width(),
+      close_button_size.height());
+  right = close_button_->x();
 
   // Layout the minimize/restore button.
   views::ImageButton* minimize_or_restore_button = NULL;
-  if (show_minimize_button)
+  if (minimize_button_->visible())
     minimize_or_restore_button = minimize_button_;
-  else if (show_restore_button)
+  else if (restore_button_->visible())
     minimize_or_restore_button = restore_button_;
   if (minimize_or_restore_button) {
     gfx::Size button_size = minimize_or_restore_button->GetPreferredSize();
     minimize_or_restore_button->SetBounds(
         right - kMinimizeButtonAndCloseButtonSpacing - button_size.width(),
         (NonClientTopBorderHeight() - button_size.height()) / 2,
         button_size.width(),
         button_size.height());
     right = minimize_or_restore_button->x();
   }
 
   // Layout the icon.
   int icon_y = (NonClientTopBorderHeight() - kIconSize) / 2;
   title_icon_->SetBounds(
       NonClientBorderThickness() + kIconAndBorderSpacing,
       icon_y,
       kIconSize,
       kIconSize);
 
   // Layout the title.
-  if (show_title_label) {
-    int title_x = title_icon_->bounds().right() + kTitleSpacing;
-    int title_height = BrowserFrame::GetTitleFont().GetHeight();
-    title_label_->SetBounds(
-        title_x,
-        icon_y + ((kIconSize - title_height - 1) / 2),
-        std::max(0, right - kTitleSpacing - title_x),
-        title_height);
-  }
+  int title_x = title_icon_->bounds().right() + kTitleSpacing;
+  int title_height = BrowserFrame::GetTitleFont().GetHeight();
+  title_label_->SetBounds(
+      title_x,
+      icon_y + ((kIconSize - title_height - 1) / 2),
+      std::max(0, right - kTitleSpacing - title_x),
+      title_height);
 
   // Calculate the client area bounds.
   int top_height = NonClientTopBorderHeight();
   int border_thickness = NonClientBorderThickness();
   client_view_bounds_.SetRect(
       border_thickness,
       top_height,
       std::max(0, width() - (2 * border_thickness)),
       std::max(0, height() - top_height - border_thickness));
 }
@@ skipping 265 matching lines @@
 }
 
 string16 PanelBrowserFrameView::GetTitleText() const {
   return frame()->widget_delegate()->GetWindowTitle();
 }
 
 void PanelBrowserFrameView::UpdateTitleBar() {
   title_label_->SetText(GetTitleText());
 }
 
+void PanelBrowserFrameView::UpdateTitleBarMinimizeRestoreButtonVisibility() {
+  Panel* panel = panel_browser_view_->panel();
+  minimize_button_->SetVisible(panel->CanMinimize());
+  restore_button_->SetVisible(panel->CanRestore());
+  Layout();

[Dmitry Titov, 2012/05/02 03:23:08]

Maybe we should layout both buttons in Layout() method, and here only switch the
visibility? Then this method would correspond to its name and purpose - simply
switch the visibility of the buttons.

[jennb, 2012/05/02 19:10:35]

Done.

+}
+
 bool PanelBrowserFrameView::CanResize() const {
   return panel_browser_view_->panel()->CanResizeByMouse() !=
       panel::NOT_RESIZABLE;
 }
 
 bool PanelBrowserFrameView::IsShowingTitlebarOnly() const {
   return height() <= kTitlebarHeight;
 }