Chromium Code Reviews
Help | Chromium Project | Sign in
(3)

Issue 10260008: Add all the linux tests to linux_clang but keep them off by default. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 4 months ago by M-A Ruel
Modified:
3 years, 4 months ago
CC:
chromium-reviews, nsylvain+cc_chromium.org, cmp+cc_chromium.org
Visibility:
Public.

Description

Add all the linux tests to linux_clang but keep them off by default. TBR=nsylvain@chromium.org BUG= TEST=Will help with bug 98635 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134502

Patch Set 1 #

Patch Set 2 : now works #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M masters/master.tryserver.chromium/master.cfg View 1 2 chunks +7 lines, -4 lines 1 comment Download
Trybot results:
Project "None" does not have a commit queue.

Messages

Total messages: 6 (0 generated)
M-A Ruel
3 years, 4 months ago (2012-04-30 00:51:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10260008/1
3 years, 4 months ago (2012-04-30 00:51:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10260008/3001
3 years, 4 months ago (2012-04-30 00:57:02 UTC) #3
commit-bot: I haz the power
Change committed as 134502
3 years, 4 months ago (2012-04-30 01:01:45 UTC) #4
nsylvain
https://chromiumcodereview.appspot.com/10260008/diff/3001/masters/master.tryserver.chromium/master.cfg File masters/master.tryserver.chromium/master.cfg (right): https://chromiumcodereview.appspot.com/10260008/diff/3001/masters/master.tryserver.chromium/master.cfg#newcode882 masters/master.tryserver.chromium/master.cfg:882: non_default=linux_tests) i thought non_default took the display name, and ...
3 years, 4 months ago (2012-04-30 15:39:38 UTC) #5
M-A Ruel
3 years, 4 months ago (2012-04-30 15:45:35 UTC) #6
On 2012/04/30 15:39:38, nsylvain wrote:
>
https://chromiumcodereview.appspot.com/10260008/diff/3001/masters/master.trys...
> File masters/master.tryserver.chromium/master.cfg (right):
> 
>
https://chromiumcodereview.appspot.com/10260008/diff/3001/masters/master.trys...
> masters/master.tryserver.chromium/master.cfg:882: non_default=linux_tests)
> i thought non_default took the display name, and not the factory name (like
> linux_tests?)

Oh, you're right, dang.
http://build.chromium.org/p/tryserver.chromium/builders/linux_clang/builds/17873
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 020f378