Chromium Code Reviews
Help | Chromium Project | Sign in
(136)

Issue 10260008: Add all the linux tests to linux_clang but keep them off by default. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 11 months ago by M-A Ruel
Modified:
1 year, 11 months ago
CC:
chromium-reviews_chromium.org, nsylvain+cc_chromium.org, cmp+cc_chromium.org
Visibility:
Public.

Description

Add all the linux tests to linux_clang but keep them off by default.

TBR=nsylvain@chromium.org
BUG=
TEST=Will help with bug 98635


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134502

Patch Set 1 #

Patch Set 2 : now works #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Lint Patch
M masters/master.tryserver.chromium/master.cfg View 1 2 chunks +7 lines, -4 lines 1 comment ? errors Download
Trybot results:
Commit:

Messages

Total messages: 6
M-A Ruel
1 year, 11 months ago #1
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10260008/1
1 year, 11 months ago #2
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10260008/3001
1 year, 11 months ago #3
I haz the power (commit-bot)
Change committed as 134502
1 year, 11 months ago #4
nsylvain
https://chromiumcodereview.appspot.com/10260008/diff/3001/masters/master.tryserver.chromium/master.cfg File masters/master.tryserver.chromium/master.cfg (right): https://chromiumcodereview.appspot.com/10260008/diff/3001/masters/master.tryserver.chromium/master.cfg#newcode882 masters/master.tryserver.chromium/master.cfg:882: non_default=linux_tests) i thought non_default took the display name, and ...
1 year, 11 months ago #5
M-A Ruel
1 year, 11 months ago #6
On 2012/04/30 15:39:38, nsylvain wrote:
>
https://chromiumcodereview.appspot.com/10260008/diff/3001/masters/master.trys...
> File masters/master.tryserver.chromium/master.cfg (right):
> 
>
https://chromiumcodereview.appspot.com/10260008/diff/3001/masters/master.trys...
> masters/master.tryserver.chromium/master.cfg:882: non_default=linux_tests)
> i thought non_default took the display name, and not the factory name (like
> linux_tests?)

Oh, you're right, dang.
http://build.chromium.org/p/tryserver.chromium/builders/linux_clang/builds/17873
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6