Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1025953002: DEPS roll for trace_viewer ff2031:8f04ee (Closed)

Created:
5 years, 9 months ago by r.kasibhatla
Modified:
5 years, 9 months ago
Reviewers:
dsinclair, nduca, qyearsley
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DEPS roll for trace_viewer ff2031:8f04ee This roll picks the fixes for the unit test failues which was causing irritating "Aw Snap!" crash of unit test renderer process in the latest ToT of chromium and trace-viewer repos. BUG=None R=nduca,dsinclair,qyearsley TESTS=None Committed: https://crrev.com/2647def7ddcd4cac4fc4750962940e41a7422f13 Cr-Commit-Position: refs/heads/master@{#321799}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
r.kasibhatla
Anybody there for quick review? Rolling the fix of qyearsley to get rid of irritating ...
5 years, 9 months ago (2015-03-23 06:17:57 UTC) #1
qyearsley
On 2015/03/23 06:17:57, r.kasibhatla wrote: > Anybody there for quick review? > Rolling the fix ...
5 years, 9 months ago (2015-03-23 16:17:24 UTC) #2
qyearsley
May want to wait for dsinclair or nduca to stamp first though in case there ...
5 years, 9 months ago (2015-03-23 16:19:05 UTC) #3
dsinclair
lgtm
5 years, 9 months ago (2015-03-23 16:19:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025953002/1
5 years, 9 months ago (2015-03-23 16:19:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-23 17:18:08 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 17:18:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2647def7ddcd4cac4fc4750962940e41a7422f13
Cr-Commit-Position: refs/heads/master@{#321799}

Powered by Google App Engine
This is Rietveld 408576698