chrome/common/extensions/docs/templates/private/relatedpages_item.html - Issue 102593005: Clean patch with DCC static content

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/docs/templates/private/relatedpages_item.html

Issue 102593005: Clean patch with DCC static content (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: addressed reviewer's comments Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 {{#r:items}}{{?r.related}}
	not at google - send to devlin 2013/12/18 05:10:14 put the {{?r.related}} on the next line; apologies put the {{?r.related}} on the next line; apologies for not documenting this anywhere, but the template rendering will look better (though again it makes no practical difference given this is all HTML anyway) Renato Mangini (chromium) 2013/12/18 13:25:30 Done. Show quoted text On 2013/12/18 05:10:14, kalman wrote: > put the {{?r.related}} on the next line; apologies for not documenting this > anywhere, but the template rendering will look better (though again it makes no > practical difference given this is all HTML anyway) Done.
	2 <li{{?r.separator}} class="separator"{{/}}>

	3 <a href="{{r.href}}"{{?r.selected}} class="active"{{/}}>{{r.title}}</a>

	4 </li>

	5 {{:r.related}}

	6 {{?r.items}}{{+partials.relatedpages_item items:r.items /}}{{/r.items}}
	not at google - send to devlin 2013/12/18 05:10:14 you should be able to do {{?r.items +partials.rel you should be able to do {{?r.items +partials.relatedpages_item items:r.items /}} Renato Mangini (chromium) 2013/12/18 13:25:30 Done. Show quoted text On 2013/12/18 05:10:14, kalman wrote: > you should be able to do > > {{?r.items +partials.relatedpages_item items:r.items /}} Done.
	7 {{/r.related}}

	8 {{/items}}

OLD	NEW