chrome/common/extensions/docs/templates/private/article.html - Issue 102593005: Clean patch with DCC static content

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/docs/templates/private/article.html

Issue 102593005: Clean patch with DCC static content (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: addressed reviewer's comments Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/common/extensions/docs/server2/sidenav_data_source.py ('K') | « chrome/common/extensions/docs/templates/json/content_providers.json ('k') | chrome/common/extensions/docs/templates/private/cc.html » ('j') | chrome/common/extensions/docs/templates/private/relatedpages_item.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {{- This is the shared template for Extension/App articles.	1 {{- This is the shared template for Extension/App articles.

2 - \|article\| The article content.	2 - \|article\| The article content.

3 - \|sidenav\| The sidenav items.

4 - \|platform\| The platform.	3 - \|platform\| The platform.

5 - \|platformTitle\| The title of the platform ("Extensions" or "Apps").	4 - \|platformTitle\| The title of the platform ("Extensions" or "Apps").

6 -}}	5 -}}

7 {{+content:partials.site	6 {{+content:partials.site

8 platform:platform	7 platform:platform

9 platformTitle:platformTitle	8 platformTitle:platformTitle}}

10 sidenav:sidenav}}	9 <article class="article-content">

11 $(table_of_contents)	10 <div itemprop="articleBody">

12 {{+article platform:platform platformTitle:platformTitle /}}	11 {{+article platform:platform platformTitle:platformTitle /}}

	12

	13 {{+partials.cc /}}
	not at google - send to devlin 2013/12/18 05:10:14 should the license be at the bottom of the page? ( should the license be at the bottom of the page? (even though the TOC is floated, so in practice makes no difference, this looks a bit odd) I would also do away with the blank lines. Renato Mangini (chromium) 2013/12/18 13:25:30 TOC does not float on narrow devices, and changing Show quoted text On 2013/12/18 05:10:14, kalman wrote: > should the license be at the bottom of the page? (even though the TOC is > floated, so in practice makes no difference, this looks a bit odd) TOC does not float on narrow devices, and changing license to the bottom effectively moves it to below TOC. I prefer the way it is (TOC always the last element in page, when not floating), and since this is what came from designers, I'd rather not change it. Show quoted text > > I would also do away with the blank lines. Done.
	14

	15 <nav class="inline-toc no-permalink">

	16 {{+partials.relatedpages_items items:sidenavs.related /}}

	17 $(table_of_contents)

	18 </nav>

	19 </div>

	20 </article>

13 {{/partials.site}}	21 {{/partials.site}}

OLD	NEW