Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Side by Side Diff: content/renderer/java/java_bridge_dispatcher.cc

Issue 102593002: Convert string16 to base::string16 in content. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/java/java_bridge_dispatcher.h" 5 #include "content/renderer/java/java_bridge_dispatcher.h"
6 6
7 #include "content/child/child_process.h" 7 #include "content/child/child_process.h"
8 #include "content/child/npapi/npobject_util.h" // For CreateNPVariant() 8 #include "content/child/npapi/npobject_util.h" // For CreateNPVariant()
9 #include "content/common/java_bridge_messages.h" 9 #include "content/common/java_bridge_messages.h"
10 #include "content/public/renderer/render_thread.h" 10 #include "content/public/renderer/render_thread.h"
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 iter != objects_.end(); ++iter) { 58 iter != objects_.end(); ++iter) {
59 // This refs the NPObject. This reference is dropped when either the window 59 // This refs the NPObject. This reference is dropped when either the window
60 // object is later cleared, or the object is GC'ed. So the object may be 60 // object is later cleared, or the object is GC'ed. So the object may be
61 // deleted at any time after OnRemoveNamedObject() is called. 61 // deleted at any time after OnRemoveNamedObject() is called.
62 web_frame->bindToWindowObject(iter->first, 62 web_frame->bindToWindowObject(iter->first,
63 NPVARIANT_TO_OBJECT(iter->second)); 63 NPVARIANT_TO_OBJECT(iter->second));
64 } 64 }
65 } 65 }
66 66
67 void JavaBridgeDispatcher::OnAddNamedObject( 67 void JavaBridgeDispatcher::OnAddNamedObject(
68 const string16& name, 68 const base::string16& name,
69 const NPVariant_Param& variant_param) { 69 const NPVariant_Param& variant_param) {
70 DCHECK_EQ(variant_param.type, NPVARIANT_PARAM_SENDER_OBJECT_ROUTING_ID); 70 DCHECK_EQ(variant_param.type, NPVARIANT_PARAM_SENDER_OBJECT_ROUTING_ID);
71 71
72 EnsureChannelIsSetUp(); 72 EnsureChannelIsSetUp();
73 if (!channel_.get()) { 73 if (!channel_.get()) {
74 // It's possible for |channel_| to be NULL if the RenderView is going away. 74 // It's possible for |channel_| to be NULL if the RenderView is going away.
75 return; 75 return;
76 } 76 }
77 77
78 // This creates an NPObject, wrapped as an NPVariant. Pass 0 for the for 78 // This creates an NPObject, wrapped as an NPVariant. Pass 0 for the for
79 // containing window, as this is only used by plugins to pump the window 79 // containing window, as this is only used by plugins to pump the window
80 // message queue when a method on a renderer-side object causes a dialog to 80 // message queue when a method on a renderer-side object causes a dialog to
81 // be displayed, and the Java Bridge does not need this functionality. The 81 // be displayed, and the Java Bridge does not need this functionality. The
82 // page URL is also not required. 82 // page URL is also not required.
83 NPVariant variant; 83 NPVariant variant;
84 bool created = 84 bool created =
85 CreateNPVariant(variant_param, channel_.get(), &variant, 0, GURL()); 85 CreateNPVariant(variant_param, channel_.get(), &variant, 0, GURL());
86 DCHECK(created); 86 DCHECK(created);
87 DCHECK_EQ(variant.type, NPVariantType_Object); 87 DCHECK_EQ(variant.type, NPVariantType_Object);
88 88
89 // The NPObject is created with a ref count of one, which we remove when 89 // The NPObject is created with a ref count of one, which we remove when
90 // OnRemoveNamedObject() is called for that object. 90 // OnRemoveNamedObject() is called for that object.
91 ObjectMap::iterator iter = objects_.find(name); 91 ObjectMap::iterator iter = objects_.find(name);
92 if (iter != objects_.end()) { 92 if (iter != objects_.end()) {
93 blink::WebBindings::releaseObject(NPVARIANT_TO_OBJECT(iter->second)); 93 blink::WebBindings::releaseObject(NPVARIANT_TO_OBJECT(iter->second));
94 } 94 }
95 objects_[name] = variant; 95 objects_[name] = variant;
96 } 96 }
97 97
98 void JavaBridgeDispatcher::OnRemoveNamedObject(const string16& name) { 98 void JavaBridgeDispatcher::OnRemoveNamedObject(const base::string16& name) {
99 if (!channel_.get()) { 99 if (!channel_.get()) {
100 DCHECK(objects_.empty()); 100 DCHECK(objects_.empty());
101 return; 101 return;
102 } 102 }
103 103
104 // Removing an object does not unbind it from JavaScript until the window 104 // Removing an object does not unbind it from JavaScript until the window
105 // object is next cleared. Note that the browser checks that the named object 105 // object is next cleared. Note that the browser checks that the named object
106 // is present. 106 // is present.
107 ObjectMap::iterator iter = objects_.find(name); 107 ObjectMap::iterator iter = objects_.find(name);
108 DCHECK(iter != objects_.end()); 108 DCHECK(iter != objects_.end());
109 blink::WebBindings::releaseObject(NPVARIANT_TO_OBJECT(iter->second)); 109 blink::WebBindings::releaseObject(NPVARIANT_TO_OBJECT(iter->second));
110 objects_.erase(iter); 110 objects_.erase(iter);
111 } 111 }
112 112
113 } // namespace content 113 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/java/java_bridge_dispatcher.h ('k') | content/renderer/media/midi_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698