Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: content/browser/renderer_host/java/java_bridge_dispatcher_host_manager.cc

Issue 102593002: Convert string16 to base::string16 in content. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/java/java_bridge_dispatcher_host_manager .h" 5 #include "content/browser/renderer_host/java/java_bridge_dispatcher_host_manager .h"
6 6
7 #include "base/android/jni_android.h" 7 #include "base/android/jni_android.h"
8 #include "base/android/jni_helper.h" 8 #include "base/android/jni_helper.h"
9 #include "base/android/scoped_java_ref.h" 9 #include "base/android/scoped_java_ref.h"
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 13 matching lines...) Expand all
24 } 24 }
25 25
26 JavaBridgeDispatcherHostManager::~JavaBridgeDispatcherHostManager() { 26 JavaBridgeDispatcherHostManager::~JavaBridgeDispatcherHostManager() {
27 for (ObjectMap::iterator iter = objects_.begin(); iter != objects_.end(); 27 for (ObjectMap::iterator iter = objects_.begin(); iter != objects_.end();
28 ++iter) { 28 ++iter) {
29 blink::WebBindings::releaseObject(iter->second); 29 blink::WebBindings::releaseObject(iter->second);
30 } 30 }
31 DCHECK_EQ(0U, instances_.size()); 31 DCHECK_EQ(0U, instances_.size());
32 } 32 }
33 33
34 void JavaBridgeDispatcherHostManager::AddNamedObject(const string16& name, 34 void JavaBridgeDispatcherHostManager::AddNamedObject(const base::string16& name,
35 NPObject* object) { 35 NPObject* object) {
36 // Record this object in a map so that we can add it into RenderViewHosts 36 // Record this object in a map so that we can add it into RenderViewHosts
37 // created later. The JavaBridgeDispatcherHost instances will take a 37 // created later. The JavaBridgeDispatcherHost instances will take a
38 // reference to the object, but we take one too, because this method can be 38 // reference to the object, but we take one too, because this method can be
39 // called before there are any such instances. 39 // called before there are any such instances.
40 blink::WebBindings::retainObject(object); 40 blink::WebBindings::retainObject(object);
41 objects_[name] = object; 41 objects_[name] = object;
42 42
43 for (InstanceMap::iterator iter = instances_.begin(); 43 for (InstanceMap::iterator iter = instances_.begin();
44 iter != instances_.end(); ++iter) { 44 iter != instances_.end(); ++iter) {
(...skipping 15 matching lines...) Expand all
60 retained_object_set.get(env); 60 retained_object_set.get(env);
61 base::android::ScopedJavaLocalRef<jobject> current_retained_object_set = 61 base::android::ScopedJavaLocalRef<jobject> current_retained_object_set =
62 retained_object_set_.get(env); 62 retained_object_set_.get(env);
63 if (!env->IsSameObject(new_retained_object_set.obj(), 63 if (!env->IsSameObject(new_retained_object_set.obj(),
64 current_retained_object_set.obj())) { 64 current_retained_object_set.obj())) {
65 DCHECK(current_retained_object_set.is_null()); 65 DCHECK(current_retained_object_set.is_null());
66 retained_object_set_ = retained_object_set; 66 retained_object_set_ = retained_object_set;
67 } 67 }
68 } 68 }
69 69
70 void JavaBridgeDispatcherHostManager::RemoveNamedObject(const string16& name) { 70 void JavaBridgeDispatcherHostManager::RemoveNamedObject(
71 const base::string16& name) {
71 ObjectMap::iterator iter = objects_.find(name); 72 ObjectMap::iterator iter = objects_.find(name);
72 if (iter == objects_.end()) { 73 if (iter == objects_.end()) {
73 return; 74 return;
74 } 75 }
75 76
76 blink::WebBindings::releaseObject(iter->second); 77 blink::WebBindings::releaseObject(iter->second);
77 objects_.erase(iter); 78 objects_.erase(iter);
78 79
79 for (InstanceMap::iterator iter = instances_.begin(); 80 for (InstanceMap::iterator iter = instances_.begin();
80 iter != instances_.end(); ++iter) { 81 iter != instances_.end(); ++iter) {
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 148
148 JNIEnv* env = base::android::AttachCurrentThread(); 149 JNIEnv* env = base::android::AttachCurrentThread();
149 base::android::ScopedJavaLocalRef<jobject> retained_object_set = 150 base::android::ScopedJavaLocalRef<jobject> retained_object_set =
150 retained_object_set_.get(env); 151 retained_object_set_.get(env);
151 if (!retained_object_set.is_null()) { 152 if (!retained_object_set.is_null()) {
152 JNI_Java_HashSet_remove(env, retained_object_set, object); 153 JNI_Java_HashSet_remove(env, retained_object_set, object);
153 } 154 }
154 } 155 }
155 156
156 } // namespace content 157 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698