Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(982)

Unified Diff: media/midi/midi_manager_alsa_unittest.cc

Issue 1025863002: Web MIDI Linux: Fix enumeration when OPL3 devices are present, and fix manufacturer extraction bugs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comments about why we special case OPL3, reformat Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/midi/midi_manager_alsa.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/midi/midi_manager_alsa_unittest.cc
diff --git a/media/midi/midi_manager_alsa_unittest.cc b/media/midi/midi_manager_alsa_unittest.cc
index 6ce46171ecd73ec92d4ae430fadc81aea42802d0..1a29334c9adab14cddf82e0b6dbeeb15c082b4dd 100644
--- a/media/midi/midi_manager_alsa_unittest.cc
+++ b/media/midi/midi_manager_alsa_unittest.cc
@@ -51,6 +51,14 @@ TEST(MidiManagerAlsaTest, ExtractManufacturer) {
"Serial MIDI (UART16550A) [Soundcanvas] at 0x3f8, irq 4"));
ASSERT_EQ("", MidiManagerAlsa::AlsaRawmidi::ExtractManufacturerString(
"", "", "", "VirMIDI", "Virtual MIDI Card 1"));
+ ASSERT_EQ("C-Media Electronics Inc",
+ MidiManagerAlsa::AlsaRawmidi::ExtractManufacturerString(
+ "", "0x13f6", "C-Media Electronics Inc", "C-Media CMI8738 MIDI",
+ "C-Media CMI8738 (model 55) at 0xd000, irq 19"));
+ ASSERT_EQ("C-Media Electronics Inc",
+ MidiManagerAlsa::AlsaRawmidi::ExtractManufacturerString(
+ "", "0x13f6", "C-Media Electronics Inc", "C-Media CMI8738 FM",
+ "C-Media CMI8738 (model 55) at 0xd000, irq 19"));
}
TEST(MidiManagerAlsaTest, JSONPortMetadata) {
« no previous file with comments | « media/midi/midi_manager_alsa.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698