Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 1025803003: Add backslashes to "Adreno (TM) 3xx" canvas/ganesh whitelist entry. (Closed)

Created:
5 years, 9 months ago by aelias_OOO_until_Jul13
Modified:
5 years, 9 months ago
Reviewers:
Zhenyao Mo, vmiura
CC:
chromium-reviews, piman+watch_chromium.org, Vangelis Kokkevis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add backslashes to "Adreno (TM) 3xx" canvas/ganesh whitelist entry. This entry didn't match because the parens were interpreted as regexp grouping instead of literal characters. I didn't notice the problem before given that K+ Adreno 3xx devices are also covered by the OpenGL ES 3.0 policy. This should actually expand the Ganesh whitelist to all pre-K Adreno 3xx devices as originally intended by r307526. BUG=467581, 424970 Committed: https://crrev.com/b7859639fdf66681108dedf7edfef1c3b9c60dc9 Cr-Commit-Position: refs/heads/master@{#321910}

Patch Set 1 #

Patch Set 2 : Try two backslashes #

Patch Set 3 : Increment version number #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M gpu/config/software_rendering_list_json.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
aelias_OOO_until_Jul13
PTAL. Another string matching problem, somewhat embarrassing :/ This means 41 went out without the ...
5 years, 9 months ago (2015-03-21 00:50:14 UTC) #2
Zhenyao Mo
On 2015/03/21 00:50:14, aelias wrote: > PTAL. Another string matching problem, somewhat embarrassing :/ This ...
5 years, 9 months ago (2015-03-21 01:18:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025803003/1
5 years, 9 months ago (2015-03-21 01:18:50 UTC) #5
vmiura
I think as this is a C++ file, there should be "\\" two back slashes ...
5 years, 9 months ago (2015-03-21 01:57:10 UTC) #6
vmiura
On 2015/03/21 01:57:10, vmiura wrote: > I think as this is a C++ file, there ...
5 years, 9 months ago (2015-03-21 01:58:48 UTC) #8
aelias_OOO_until_Jul13
On 2015/03/21 at 01:58:48, vmiura wrote: > On 2015/03/21 01:57:10, vmiura wrote: > > I ...
5 years, 9 months ago (2015-03-21 02:21:21 UTC) #9
aelias_OOO_until_Jul13
Well, GpuBlacklistTest.CurrentBlacklistValidation didn't like the single backslash, so I switched to the two backslashes. PTAL
5 years, 9 months ago (2015-03-23 19:43:50 UTC) #11
vmiura
On 2015/03/23 19:43:50, aelias wrote: > Well, GpuBlacklistTest.CurrentBlacklistValidation didn't like the single > backslash, so ...
5 years, 9 months ago (2015-03-23 19:48:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025803003/40001
5 years, 9 months ago (2015-03-23 21:18:23 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/46252)
5 years, 9 months ago (2015-03-23 23:10:52 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025803003/40001
5 years, 9 months ago (2015-03-23 23:50:50 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-24 00:27:48 UTC) #20
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 00:28:48 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b7859639fdf66681108dedf7edfef1c3b9c60dc9
Cr-Commit-Position: refs/heads/master@{#321910}

Powered by Google App Engine
This is Rietveld 408576698