Mac: Possible fix for Cmd-W closing window instead of a tab

Mac: Possible fix for Cmd-W closing window instead of a tab

This logic was simplified and made more robust with
http://crrev.com/848003006, but there is still a report that this is still a
problem.

I am suspicious of the popover detection logic. The popover could belong
to any window, and could be in the middle of fading in or out. Change the
logic to a hopefully more robust on-demand detection using
[NSApplication targetForAction:@selector(performClose:].

BUG=47134
Committed: https://crrev.com/af2fb789440741f43adcc992bf5a13beccb3dba6
Cr-Commit-Position: refs/heads/master@{#322075}

[Andre, 2015-03-20 21:15:29]

andresantoso@chromium.org changed reviewers:
+ rsesek@chromium.org

[Andre, 2015-03-20 21:15:31]

Robert PTAL.

[Robert Sesek, 2015-03-23 17:48:49]

If you have the Lookup in Dictionary popup open and press Cmd+W, what happens?

It looks like this logic was added in http://codereview.chromium.org/9230011.

[Andre, 2015-03-24 20:17:23]

On 2015/03/23 17:48:49, Robert Sesek wrote:
> If you have the Lookup in Dictionary popup open and press Cmd+W, what happens?
> 
> It looks like this logic was added in http://codereview.chromium.org/9230011.

Cmd+W will still close the dictionary popup, which is the same behavior as
before the change.
-targetForAction: will return the dictionary lookup popover, which is not a
NSWindow subclass.

[Robert Sesek, 2015-03-24 20:52:13]

LGTM

[Andre, 2015-03-24 20:56:05]

The CQ bit was checked by andresantoso@chromium.org

[commit-bot: I haz the power, 2015-03-24 20:56:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1025793002/1

[commit-bot: I haz the power, 2015-03-24 21:40:34]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-24 21:41:28]

Patchset 1 (id:??) landed as
https://crrev.com/af2fb789440741f43adcc992bf5a13beccb3dba6
Cr-Commit-Position: refs/heads/master@{#322075}