Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: content/renderer/devtools/v8_sampling_profiler_browsertest.cc

Issue 1025753003: Fix compilation on non-x86 arch after r321565 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/devtools/v8_sampling_profiler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/devtools/v8_sampling_profiler_browsertest.cc
diff --git a/content/renderer/devtools/v8_sampling_profiler_browsertest.cc b/content/renderer/devtools/v8_sampling_profiler_browsertest.cc
index 7d7d5eab0049da8199e00b84862ad5c876065016..958c7966734aab51259d2d12621e4b7528807c30 100644
--- a/content/renderer/devtools/v8_sampling_profiler_browsertest.cc
+++ b/content/renderer/devtools/v8_sampling_profiler_browsertest.cc
@@ -118,11 +118,11 @@ class V8SamplingProfilerTest : public RenderViewTest {
TraceResultBuffer::SimpleOutput json_output_;
};
-// TODO(alph): Implement on Windows, Android and ChromeOS.
+// TODO(alph): Implement on Windows, Android and non-x86.
// The SamplingEventForTesting is fired when the framework collected at
// least one JitCodeAdded event and one sample event.
-#if defined(OS_WIN) || defined(OS_ANDROID) || defined(OS_CHROMEOS)
+#if defined(OS_WIN) || defined(OS_ANDROID) || !defined(ARCH_CPU_X86_FAMILY)
#define MAYBE(x) DISABLED_##x
#else
#define MAYBE(x) x
« no previous file with comments | « content/renderer/devtools/v8_sampling_profiler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698