Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1025743002: Write the assigned notification id to the stored notification data. (Closed)

Created:
5 years, 9 months ago by Peter Beverloo
Modified:
5 years, 9 months ago
Reviewers:
johnme
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Write the assigned notification id to the stored notification data. This makes sure that when the notifications are being retrieved, they always have the appropriate ID set. BUG=447628 Committed: https://crrev.com/d5c5bf15d23b854079b1494e0a44210e30cce79f Cr-Commit-Position: refs/heads/master@{#321611}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -4 lines) Patch
M content/browser/notifications/notification_database.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M content/browser/notifications/notification_database_unittest.cc View 2 chunks +26 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Peter Beverloo
+johnme
5 years, 9 months ago (2015-03-20 17:54:33 UTC) #2
johnme
lgtm
5 years, 9 months ago (2015-03-20 18:16:17 UTC) #3
johnme
lgtm lgtm
5 years, 9 months ago (2015-03-20 18:16:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025743002/1
5 years, 9 months ago (2015-03-20 18:18:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-20 19:14:50 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 19:15:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d5c5bf15d23b854079b1494e0a44210e30cce79f
Cr-Commit-Position: refs/heads/master@{#321611}

Powered by Google App Engine
This is Rietveld 408576698