Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 10257030: Added cross-build option in Makefile wrapper for gyp. (Closed)

Created:
8 years, 7 months ago by kalmard
Modified:
8 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Added cross-build option in Makefile wrapper for gyp. BUG= TEST=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M Makefile View 4 chunks +17 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
kalmard
Usage example (after setting up $CC and $CXX): make cross target=mips BUILDTYPE=Debug BUILDTYPE can be ...
8 years, 7 months ago (2012-04-28 08:40:38 UTC) #1
danno
lgtm
8 years, 7 months ago (2012-04-30 07:06:35 UTC) #2
Jakob Kummerow
The change itself looks OK, but I don't like the general direction this is going. ...
8 years, 7 months ago (2012-04-30 09:01:49 UTC) #3
kalmard
On 2012/04/30 09:01:49, Jakob wrote: > "make arm" already works for simulator builds, cross-compile builds ...
8 years, 7 months ago (2012-04-30 10:25:24 UTC) #4
Jakob Kummerow
Have a look at https://chromiumcodereview.appspot.com/10268010. The compiler seems happy both for cross-compilation and simulator builds; ...
8 years, 7 months ago (2012-04-30 15:16:15 UTC) #5
Paul Lind
On 2012/04/30 15:16:15, Jakob wrote: > lithium-codegen-mips.cc currently doesn't compile at all, so I couldn't ...
8 years, 7 months ago (2012-04-30 15:47:06 UTC) #6
palfia
On 2012/04/30 15:16:15, Jakob wrote: > Have a look at https://chromiumcodereview.appspot.com/10268010. The compiler > seems ...
8 years, 7 months ago (2012-05-02 18:41:59 UTC) #7
Jakob Kummerow
I've landed https://chromiumcodereview.appspot.com/10268010. With the fix from https://chromiumcodereview.appspot.com/10233019/ applied in addition, it compiles fine both ...
8 years, 7 months ago (2012-05-03 09:20:20 UTC) #8
palfia
8 years, 7 months ago (2012-05-03 21:50:36 UTC) #9
On 2012/05/03 09:20:20, Jakob wrote:
> I've landed https://chromiumcodereview.appspot.com/10268010.
> 
> With the fix from https://chromiumcodereview.appspot.com/10233019/ applied in
> addition, it compiles fine both for a simulator build (on Ubuntu Precise, but
> Lucid should work too) and a cross-compile build (with the CodeSourcery
> toolchain).

It works for me as well on Lucid.

> Can we close this CL?

Yes, it can be closed, thank you.

Powered by Google App Engine
This is Rietveld 408576698