Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 1025653004: Clean up - VideoRendererInterface should not have SetSize anymore. (Closed)

Created:
5 years, 9 months ago by guoweis_left_chromium
Modified:
5 years, 9 months ago
Reviewers:
perkj_chrome
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

With the introduction of CVO, VideoRendererInterface implementation should handle rotation frame by either rotating in renderer or calling into GetCopyWithRotationApplied. BUG=webrtc:4145 Committed: https://crrev.com/2537f5aac078f40df15635866b9526174a3bdfa7 Cr-Commit-Position: refs/heads/master@{#321871}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -12 lines) Patch
M content/renderer/media/webrtc/media_stream_remote_video_source.cc View 2 chunks +8 lines, -11 lines 0 comments Download
M content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
guoweis_left_chromium
PTAL.
5 years, 9 months ago (2015-03-20 18:36:20 UTC) #2
perkj_chrome
please add a valid bug number to cvo. webrtc::xxxx might work, if not, create a ...
5 years, 9 months ago (2015-03-23 06:55:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025653004/20001
5 years, 9 months ago (2015-03-23 20:23:09 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-23 22:21:39 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 22:22:33 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2537f5aac078f40df15635866b9526174a3bdfa7
Cr-Commit-Position: refs/heads/master@{#321871}

Powered by Google App Engine
This is Rietveld 408576698