Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Unified Diff: chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc

Issue 1025653003: Disable WebViewInteractiveTest.Fullscreen{Allow,Deny}_* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@disable_dnsprefetch
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
diff --git a/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc b/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
index c5658c8d453c315ae91ec2ae72bfe61f29de011b..89a60997976470f8c1fc120b2984a3ea84c76637 100644
--- a/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
+++ b/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
@@ -1023,34 +1023,29 @@ IN_PROC_BROWSER_TEST_F(WebViewInteractiveTest,
// "*** Assertion failure in -[_NSWindowFullScreenTransition
// transitionedWindowFrame],"
// See similar bug: http://crbug.com/169820.
-// Also flaky on Windows: http://crbug.com/468660
-#if defined(OS_MACOSX) || defined(OS_WIN)
-#define MAYBE_FullscreenAllow_EmbedderHasPermission \
- DISABLED_FullscreenAllow_EmbedderHasPermission
-#else
-#define MAYBE_FullscreenAllow_EmbedderHasPermission \
- FullscreenAllow_EmbedderHasPermission
-#endif
+//
+// In addition to the above, these tests are flaky on many platforms:
+// http://crbug.com/468660
IN_PROC_BROWSER_TEST_F(WebViewInteractiveTest,
- MAYBE_FullscreenAllow_EmbedderHasPermission) {
+ DISABLED_FullscreenAllow_EmbedderHasPermission) {
FullscreenTestHelper("testFullscreenAllow",
"web_view/fullscreen/embedder_has_permission");
}
IN_PROC_BROWSER_TEST_F(WebViewInteractiveTest,
- FullscreenDeny_EmbedderHasPermission) {
+ DISABLED_FullscreenDeny_EmbedderHasPermission) {
FullscreenTestHelper("testFullscreenDeny",
"web_view/fullscreen/embedder_has_permission");
}
IN_PROC_BROWSER_TEST_F(WebViewInteractiveTest,
- FullscreenAllow_EmbedderHasNoPermission) {
+ DISABLED_FullscreenAllow_EmbedderHasNoPermission) {
FullscreenTestHelper("testFullscreenAllow",
"web_view/fullscreen/embedder_has_no_permission");
}
IN_PROC_BROWSER_TEST_F(WebViewInteractiveTest,
- FullscreenDeny_EmbedderHasNoPermission) {
+ DISABLED_FullscreenDeny_EmbedderHasNoPermission) {
FullscreenTestHelper("testFullscreenDeny",
"web_view/fullscreen/embedder_has_no_permission");
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698