Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Unified Diff: src/heap/heap.cc

Issue 1025643002: Respect old space allocation limit in PagedSpace::AllocateRaw. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap/spaces.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index 054ebced2a899ff2d20941a4d4b76638de122f8a..fe02f3167f43c0b105a01b2b254570ea6ba7e78e 100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -1867,6 +1867,10 @@ class NewSpaceScavenger : public StaticNewSpaceVisitor<NewSpaceScavenger> {
Address Heap::DoScavenge(ObjectVisitor* scavenge_visitor,
Address new_space_front) {
+ // There are soft limits in the allocation code, designed trigger a mark
+ // sweep collection by failing allocations. There is no sense in trying to
Hannes Payer (out of office) 2015/03/20 12:29:27 designed to... For scavenges allocation should alw
+ // trigger one in during scavenge.
+ AlwaysAllocateScope scope(isolate());
do {
SemiSpace::AssertValidRange(new_space_front, new_space_.top());
// The addresses new_space_front and new_space_.top() define a
« no previous file with comments | « no previous file | src/heap/spaces.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698